public inbox for [email protected]  

help / color / mirror / Atom feed

From: Michael Paquier <[email protected]>
To: zhanghu <[email protected]>
Cc: Postgres hackers <[email protected]>
Subject: Re: Add documentation for PG_ABS_SRCDIR, PG_ABS_BUILDDIR, PG_LIBDIR, PG_DLSUFFIX
Date: Thu, 12 Mar 2026 06:34:51 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAB5m2Qt_jQ2UJNainsp+jhzjRS6rCPd5ti1MBwDoJnXXG2v_Vg@mail.gmail.com>
References: <[email protected]>
	<CAB5m2Qt_jQ2UJNainsp+jhzjRS6rCPd5ti1MBwDoJnXXG2v_Vg@mail.gmail.com>

On Wed, Mar 11, 2026 at 11:10:44AM +0800, zhanghu wrote:
> The doc changes look good overall. I applied the patch locally and rendered
> the documentation to HTML, the new page also looks good.
> 
> A few minor nitpicks:
> 
> +       <para>
> +        Name of extension for dynamically-loadable modules (e.g.
> +        <literal>.so</literal> on Linux).
> +       </para>
> 
> I think we need a "the" before "dynamically-loadable".

Don't think this one's necessary here, actually, as it refers to a
general concept around modules.

> +      These are useful when dealing with function and object loading
> +      that require specific paths to work, like paths defined in a
> +      <command>CREATE FUNCTION</command> or <command>LOAD</command>
> +      command, for example.
> 
> The ending "for example" sounds redundant, since "like" already conveys the
> meaning of "for example".

WFM.
--
Michael


Attachments:

  [application/pgp-signature] signature.asc (833B, 2-signature.asc)
  download

view thread (5+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Add documentation for PG_ABS_SRCDIR, PG_ABS_BUILDDIR, PG_LIBDIR, PG_DLSUFFIX
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox