pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Jonathan S. Katz <jkatz@postgresql.org>
To: Stephen Frost <sfrost@snowman.net>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org, Amit Kapila <amit.kapila16@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Subject: Re: longfin missing gssapi_ext.h
Date: Wed, 12 Apr 2023 10:54:53 -0400
Message-ID: <abcc73d0-acf7-6896-e0dc-f5bc12a61bb1@postgresql.org> (raw)
In-Reply-To: <ZDbEnh7KMx9xBG2a@tamriel.snowman.net>
References: <CA+hUKGLjDaFL8+LtoedNKEHhqRsWBURkw2Q=m=-GBbr0f7eoGw@mail.gmail.com>
	<ZDQd2vxptNARaX/C@tamriel.snowman.net>
	<4077651.1681139807@sss.pgh.pa.us>
	<ZDQrhhsUb+X+WX9q@tamriel.snowman.net>
	<4080250.1681141040@sss.pgh.pa.us>
	<eeb2be64-dcd7-e46c-04b4-0726eb44f901@postgresql.org>
	<ZDYG0GkWQa3uZ8yI@tamriel.snowman.net>
	<763952.1681272015@sss.pgh.pa.us>
	<ZDbBMr1LVy60mAS+@tamriel.snowman.net>
	<bcca89d6-9c87-1a92-60dc-229edc758a79@postgresql.org>
	<ZDbEnh7KMx9xBG2a@tamriel.snowman.net>

On 4/12/23 10:47 AM, Stephen Frost wrote:
> Greetings,
> 
> * Jonathan S. Katz (jkatz@postgresql.org) wrote:
>> On 4/12/23 10:33 AM, Stephen Frost wrote:
>>> * Tom Lane (tgl@sss.pgh.pa.us) wrote:
>>>> Stephen Frost <sfrost@snowman.net> writes:
>>>>> Understood.  Please find attached the updated patch with changes to the
>>>>> commit message to indicate that we now require MIT Kerberos, an
>>>>> additional explicit check for gssapi_ext.h in configure.ac/configure,
>>>>> along with updated documentation explicitly saying we require MIT
>>>>> Kerberos for GSSAPI support.
>>>>
>>>> Um ... could you package this as a straight un-revert of the
>>>> previous commit, then a delta patch?  Would be easier to review.
>>>
>>> Sure, reworked that way and attached.
>>
>> Docs read well. A few questions/commenets:
>>
>> * On [1] -- do we want to add a note that it's not just Kerberos, but MIT
>> Kerberos?
> 
> Yes, makes sense, updated.
> 
>> * On [2] -- we mention "kadmin tool of MIT-compatible Kerberos 5" which is
>> AIUI is still technically correct, but do we want to drop the "-compatible?"
>> (precedent in [3])
> 
> Yup, cleaned that up also.
> 
> Updated patch set attached.

Thanks! I'll sign off on the docs portion.

The meson build code looks good to me (I just compared it to what 
already exists). Similar comment to the autoconf code.

Thanks,

Jonathan


Attachments:

  OpenPGP_signature (application/pgp-signature, 839B) download

view thread (48+ messages)  latest in thread

Message-ID: <abcc73d0-acf7-6896-e0dc-f5bc12a61bb1@postgresql.org>
Permalink:  ../abcc73d0-acf7-6896-e0dc-f5bc12a61bb1@postgresql.org/
Also on:    postgresql.org/message-id/abcc73d0-acf7-6896-e0dc-f5bc12a61bb1@postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: jkatz@postgresql.org, sfrost@snowman.net, tgl@sss.pgh.pa.us, thomas.munro@gmail.com, amit.kapila16@gmail.com, alvherre@alvh.no-ip.org
  Subject: Re: longfin missing gssapi_ext.h
  In-Reply-To: <abcc73d0-acf7-6896-e0dc-f5bc12a61bb1@postgresql.org>
  References: <CA+hUKGLjDaFL8+LtoedNKEHhqRsWBURkw2Q=m=-GBbr0f7eoGw@mail.gmail.com> <ZDQd2vxptNARaX/C@tamriel.snowman.net> <4077651.1681139807@sss.pgh.pa.us> <ZDQrhhsUb+X+WX9q@tamriel.snowman.net> <4080250.1681141040@sss.pgh.pa.us> <eeb2be64-dcd7-e46c-04b4-0726eb44f901@postgresql.org> <ZDYG0GkWQa3uZ8yI@tamriel.snowman.net> <763952.1681272015@sss.pgh.pa.us> <ZDbBMr1LVy60mAS+@tamriel.snowman.net> <bcca89d6-9c87-1a92-60dc-229edc758a79@postgresql.org> <ZDbEnh7KMx9xBG2a@tamriel.snowman.net> <abcc73d0-acf7-6896-e0dc-f5bc12a61bb1@postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox