public inbox for [email protected]  

help / color / mirror / Atom feed
From: Michael Paquier <[email protected]>
To: Chao Li <[email protected]>
Cc: Postgres hackers <[email protected]>
Subject: Re: tablecmds: reject CLUSTER ON for partitioned tables earlier
Date: Mon, 16 Mar 2026 17:51:34 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CAEoWx2k5800OjHO5KhTDv4JFYpDmyfh3MTtuB=7PP-0hLmG8yQ@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CAN4CZFMUJWM0veLK93Ew8mYaL5pcU6G550STh6AZ-_LWV2zS+w@mail.gmail.com>
	<[email protected]>
	<CAN4CZFPX_t9q4W=jTh4jW4TOz=Xhfv0gPi9jG0MfXv9Ek7BO5w@mail.gmail.com>
	<[email protected]>
	<CAN4CZFMjyPYqNY6qD4ArRZKUyC4oEPAfu-OesfChGMwMq1CG_w@mail.gmail.com>
	<[email protected]>
	<[email protected]>

On Fri, Mar 13, 2026 at 11:38:17AM +0800, Chao Li wrote:
> On Jan 28, 2026, at 10:15, Chao Li <[email protected]> wrote:
>> * In 0001, replaced ereport with assert in
>> mark_index_clustered(). See my previous email for the analysis. 

I have looked at this one, and I think that it is right.  Even in the
CLUSTER/VACUUM path, we have a relkind check before the sole caller of
rebuild_relation() that discards partitioned tables, so we would never
read mark_index_clustered() under this relkind.  Applied.

>> * In 0002, removed the redundant check of relispartition from
>> * ATExecDropInherit().

I have not looked at this one.
--
Michael


Attachments:

  [application/pgp-signature] signature.asc (833B, 2-signature.asc)
  download

view thread (6+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: tablecmds: reject CLUSTER ON for partitioned tables earlier
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox