public inbox for [email protected]  
help / color / mirror / Atom feed
From: Bertrand Drouvot <[email protected]>
To: Peter Eisentraut <[email protected]>
Cc: [email protected]
Subject: Re: Enable -Wstrict-prototypes and -Wold-style-definition by default
Date: Wed, 25 Mar 2026 03:17:35 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <aa73q1aT0A3/vke/@ip-10-97-1-34.eu-west-3.compute.internal>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

Hi,

On Tue, Mar 24, 2026 at 10:36:43PM +0100, Peter Eisentraut wrote:
> On 24.03.26 08:16, Bertrand Drouvot wrote:
> > 0001:
> > 
> > +    '/external:anglebrackets',
> > +    '/external:W0',
> > 
> > The doc [1], states:
> > 
> > "
> > The /external compiler options are available starting in Visual Studio 2017 version 15.6.
> > In versions of Visual Studio before Visual Studio 2019 version 16.10, the /external
> > options require you also set the /experimental:external compiler option.
> > "
> > 
> > We currently require MSVC 2019, but what if one is using a version < 16.10?
> 
> Per discussion in [0] we effectively require 16.11, so I think this should
> be ok.

Agree, thanks for the link!

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com





view thread (18+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Enable -Wstrict-prototypes and -Wold-style-definition by default
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox