public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Aleksander Alekseev <[email protected]>
Cc: PostgreSQL Development <[email protected]>
Cc: Andrey Borodin <[email protected]>
Cc: John Naylor <[email protected]>
Cc: Tom Lane <[email protected]>
Subject: Re: [PATCH] Simplify SortSupport implementation for macaddr
Date: Wed, 25 Mar 2026 17:00:04 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAJ7c6TPoPMfGwVuM14T7KuWVcRaoE3-nd3goLoE5zss4JzAExw@mail.gmail.com>
References: <CAJ7c6TMk10rF_LiMz6j9rRy1rqk-5s+wBPuBefLix4cY+-4s1w@mail.gmail.com>
<[email protected]>
<CAJ7c6TPoPMfGwVuM14T7KuWVcRaoE3-nd3goLoE5zss4JzAExw@mail.gmail.com>
On Mon, Mar 09, 2026 at 04:08:06PM +0300, Aleksander Alekseev wrote:
>> 1. The assignment ssup->ssup_extra = NULL can be removed. The
>> SortSupport struct is zeroed before the callback is called (see
>> sortsupport.h). There are about 22 similar assignments elsewhere;
>> it does not seem to be established practice, many other places have
>> no such assignment.
>
> Agree. I removed this assignment in 0001 and added 0002 that removes
> if for the rest of *_sortsupport() functions.
Sounds sensible to get rid of the estimation with the Datum size
requirement and never give up with the abbreviated key sort, as done
in 0001. I'd leave the code touched by 0002 remain as-is.
@Tom, why didn't you consider that as a continuation of 6aebedc38497?
Just to keep the changes with SIZEOF_DATUM < 8 leaner, or just because
it was not worth bothering based on your TODO list? I am wondering if
there is a reason I may be missing here.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, 2-signature.asc)
download
view thread (5+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: [PATCH] Simplify SortSupport implementation for macaddr
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox