public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Lukas Fittl <[email protected]>
Cc: Sami Imseih <[email protected]>
Cc: zengman <[email protected]>
Cc: pgsql-hackers <[email protected]>
Cc: Julien Rouhaud <[email protected]>
Subject: Re: Refactor query normalization into core query jumbling
Date: Sun, 5 Apr 2026 21:04:53 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAP53Pkx2s7O_fbmLoReKMeOXwp9Z=9e3uW4Tp9RMw99z_dSaiQ@mail.gmail.com>
References: <CAA5RZ0ui6JSDPQDs2RW7eBDvrH_t_xg8bhUM8FaxawU8wDoMFg@mail.gmail.com>
<[email protected]>
<CAP53Pkwb2f288Ji2s9ZZTL0_PEyYCZpQjBtD63X_s+yUB3YORA@mail.gmail.com>
<CAA5RZ0vrXNndS6rGx43q+h9JNtxnUzZnxgP_zWSc9LHXS36bXg@mail.gmail.com>
<[email protected]>
<CAA5RZ0ufGxCCoPBHKV2mLo9CzHe83w1L-mhx5XHU4axXkMHirw@mail.gmail.com>
<CAP53Pkx2s7O_fbmLoReKMeOXwp9Z=9e3uW4Tp9RMw99z_dSaiQ@mail.gmail.com>
On Wed, Apr 01, 2026 at 12:55:28AM -0700, Lukas Fittl wrote:
> On Tue, Mar 31, 2026 at 7:54 PM Sami Imseih <[email protected]> wrote:
>>
>> > I'm +-0 regarding this routine, but I can also see your point about how it's
>> > useful to give at least the option to extensions to have a
>> > recomputation of the Const lengths, the same way as PGSS. What are
>> > the extensions that would use that?
>>
>> https://github.com/search?q=fill_in_constant_lengths&type=code
>>
>> A few well-known extensions/tools out there based on a Github search.
FWIW, this search points to a lot of forks
> See attached a v9 that extracts ComputeConstantLengths from Sami's v7
> for easier discussion.
>
> I've done an updated test with pg_stat_monitor [0] and pg_tracing [1]
> with that, and that has both extensions passing regressions tests.
> I've also looked but not tested a third extension (sql_firewall) and
> that looks like it should just work as well.
Still I can see the gains here, so I guess that this version works
here. I'm happy enough to see the const with JumbleState.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, 2-signature.asc)
download
view thread (34+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Refactor query normalization into core query jumbling
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox