From: Mark Wong <markwkm@gmail.com>
To: Andreas Karlsson <andreas@proxel.se>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: updates for handling optional argument in system functions
Date: Tue, 7 Apr 2026 16:42:23 -0700
Message-ID: <adWWX4jFbxib8oQ1@ltdrgnflg2> (raw)
In-Reply-To: <6de20662-36fd-4e00-a0b0-75d1e9deb5c8@proxel.se>
References: <aTiwu9o8vBkLreAL@ltdrgnflg2>
<ac63G6p1LAdbsca0@ltdrgnflg2>
<6de20662-36fd-4e00-a0b0-75d1e9deb5c8@proxel.se>
On Wed, Apr 08, 2026 at 12:26:05AM +0200, Andreas Karlsson wrote:
> On 4/2/26 8:36 PM, Mark Wong wrote:
> > I've attached v5, simply a needed rebase due to some other churn in
> > pg_proc.dat.
>
> Nice, I like the patch. The code changes looks good and I like the
> removal of these duplicate functions and use of default arguments. But I
> think the names of the arguments should be aligned with the names we
> have in the documentation. And that may mean that we should change the
> documentation.
Thanks!
> For example:
>
> = Code
>
> pg_get_ruledef(rule, pretty)
>
> = Docs
>
> pg_get_ruledef(rule_oid, pretty_bool)
>
> = Should docs maybe be updated to the following?
>
> pg_get_ruledef(rule oid, pretty bool)
I agree with the aligning the names, but maybe I was looking in a
different place?
In the doc/src/sgml/func/func-info.sgml (a4f774cf1c7e) I think I see
pg_get_ruledef(rule oid, pretty bool) already:
<function>pg_get_ruledef</function> ( <parameter>rule</parameter> <type>oid</type> <optional>, <parameter>pretty</parameter> <type>boolean</type> </optional> )
I don't see any matches when I grep for rule_oid or pretty_bool...
Regards,
Mark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: markwkm@gmail.com, andreas@proxel.se, pgsql-hackers@lists.postgresql.org
Subject: Re: updates for handling optional argument in system functions
In-Reply-To: <adWWX4jFbxib8oQ1@ltdrgnflg2>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox