public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Sami Imseih <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Thomas Munro <[email protected]>
Subject: Re: dshash_find_or_insert vs. OOM
Date: Wed, 8 Apr 2026 10:04:50 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAA5RZ0sX9e2F7ePKxx_805=Wk2BVN2WHhvRhrfd3XBNkvebE9A@mail.gmail.com>
References: <CA+TgmoaJwUukUZGu7_yL74oMTQQz2=zqucMhF9+9xBmSC5us1w@mail.gmail.com>
<CAA5RZ0vNVdBnm_TSCR5K6fT7yc7-jQuneNUYFxFgS7hQnn62sA@mail.gmail.com>
<CA+TgmoZ3cd+wh1vz8gB_iD9zxZX558xUERaPm7G-M8wa7p9GNg@mail.gmail.com>
<CAA5RZ0tWjsthTod0ODPEW4noNrSvY+gRWTMxiQ89-yY-k92B8Q@mail.gmail.com>
<CAA5RZ0uhz2uEtUV1KqoCHKQY4U3pgB6N1n-oR-gy8TPUoenQSA@mail.gmail.com>
<CA+TgmoYmzRbNjx8sbm_0Hk-VtLBtJPe=juOUSFkm7ge4Xy7hYw@mail.gmail.com>
<gq55lyolnqm4yv7texawu7sr64btcczktu7hd4byl6zarxkibv@pb6ajailtqop>
<[email protected]>
<CAA5RZ0sX9e2F7ePKxx_805=Wk2BVN2WHhvRhrfd3XBNkvebE9A@mail.gmail.com>
On Tue, Apr 07, 2026 at 12:00:14PM -0500, Sami Imseih wrote:
> My apologies for the late response here. I spent some time looking at
> this yesterday and came to the conclusion that we can add dshash tests
> to test_dsm_registry, which already allocates a dshash via
> GetNamedDSHash(). However, I also realized that the API has a gap: callers
> cannot set a size limit on the dshash. I need this for the test, but
> more importantly it's a limitation of the API itself.
As in dsa_set_size_limit() cannot be set for a dshash currently.
Indeed that could be independently useful for some use cases.
> So I plan to
> target v20 for the tests, as it's likely too late for v19. To start, I've
> submitted a patch for allowing callers to set a size limit on a
> GetNamedDSHash()-allocated dshash [1].
>
> [1] https://commitfest.postgresql.org/patch/6655/
That's too late for v19, at least here. Thanks for pursuing this
work.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, 2-signature.asc)
download
view thread (15+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: dshash_find_or_insert vs. OOM
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox