From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alexander Lakhin <exclusion@gmail.com>
Cc: Sami Imseih <samimseih@gmail.com>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Robert Treat <rob@xzilla.net>
Cc: satyanarlapuram@gmail.com, pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: tndrwang@gmail.com
Subject: Re: Add pg_stat_autovacuum_priority
Date: Wed, 8 Apr 2026 14:09:48 -0500
Message-ID: <adan_E0o69p81lIj@nathan> (raw)
In-Reply-To: <3097984.1775674400@sss.pgh.pa.us>
References: <CAA5RZ0vxby2osMMaCuZ=680tmt583cF9n4rOzTGdsiS-1PJknA@mail.gmail.com>
<adE9RbcA7lhH_w2d@nathan>
<CAA5RZ0tYzPDeXbqz9uKacRV2xjD055qrg=s3w2PEQPK8EruuSg@mail.gmail.com>
<adFiCgN22xJ7Z-oR@nathan>
<CAA5RZ0vRP-W2wJD2OxEb-=VGj2sp5pMCqHQg9YJiuDVPhaY5jQ@mail.gmail.com>
<adQsdvPPNviWMCXb@nathan>
<5684f479-858e-4c5d-b8f5-bcf05de1f909@gmail.com>
<3077290.1775668665@sss.pgh.pa.us>
<adaWuTR7oCKodH7k@nathan>
<3097984.1775674400@sss.pgh.pa.us>
On Wed, Apr 08, 2026 at 02:53:20PM -0400, Tom Lane wrote:
> Oh. I'm not happy that any part of autovacuum.c is now reachable from
> SQL: that's the sort of modularity violation that will bite us on the
> ass (indeed just did). Aside from this problem, the elog's that
> relation_needs_vacanalyze emits seem 100% inappropriate and misleading
> when it's being called from the view.
FWIW that elog() shouldn't be emitting anything from the view, unless
something is broken.
> I think perhaps the right way forward is to rethink the API
> guarantees for pgstat_fetch_stat_tabentry_ext, as I speculated
> about in 02502c1bc:
>
> [...]
>
> 2. Add a "bool *should_free" parameter, like we have in tuplestores
> and some other places. It's on the caller to pfree if should_free
> gets set, but since we'd have to touch every caller, we'd not miss
> any.
This sounds most similar to the "bool *may_free" idea that Andres just
posted. IIUC the idea is that callers can free the result if they want,
but they aren't required to do so.
--
nathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, tgl@sss.pgh.pa.us, exclusion@gmail.com, samimseih@gmail.com, bharath.rupireddyforpostgres@gmail.com, rob@xzilla.net, tndrwang@gmail.com
Subject: Re: Add pg_stat_autovacuum_priority
In-Reply-To: <adan_E0o69p81lIj@nathan>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox