public inbox for [email protected]  

help / color / mirror / Atom feed

From: Bertrand Drouvot <[email protected]>
To: Peter Eisentraut <[email protected]>
Cc: Jelte Fennema-Nio <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Thomas Munro <[email protected]>
Cc: Andres Freund <[email protected]>
Subject: Re: Make copyObject work in C++
Date: Thu, 9 Apr 2026 11:41:39 +0000
Message-ID: <adeQc3I/[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<2h2n2gyw2f4ucicbl3drtdkjt2wzf6b2r4wqm7xwks6vpx5j7n@imymv4hkz5jz>
	<[email protected]>
	<[email protected]>
	<CAGECzQSB=rBZ2n1WeCRAQ09xHzHSpyVBk-+NWEAcLsegsRXPzA@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CAGECzQRauVYN19Y-DTiCTCkdNabh+ZqhdaLrUHR6CAU4wm2TFQ@mail.gmail.com>
	<[email protected]>

Hi,

On Wed, Apr 01, 2026 at 07:54:07AM +0200, Peter Eisentraut wrote:
> On 31.03.26 11:09, Jelte Fennema-Nio wrote:
> > On Tue, 31 Mar 2026 at 10:33, Peter Eisentraut <[email protected]> wrote:
> > > Hmm, note that C++ is also used for LLVM/JIT, and by requiring this
> > > additional feature set we are also imposing new requirements for those
> > > users.  This has not been fully explored, and I hesitate to add such a
> > > new requirement at the last moment.
> > 
> > I understand the hesitation, but in practice we already impose those
> > requirements anyway for non-MSVC compilers because test_cplusplusext
> > doesn't compile without it. So any compiler that would cause problems
> > with the new featureset would have already complained about that
> > before.
> > 
> > > But how about this: We add the feature test that you propose and enable
> > > the extension based on that.  See attached patch.  This reduces to
> > > essentially a three-line patch, much simpler than all previous proposals.
> > 
> > If you're still worried, then this sounds like a fine middle-ground
> > for now. I think we should reconsider adding the automatic /std:c++20
> > flag for the PG20 dev cycle though.
> 
> Ok, I have committed the shown patch.

d50c86e74375 added a comment mentionning that StaticAssertStmt is deprecated, so
we really need the one added in test_cplusplusext.cpp?

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

view thread (39+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Make copyObject work in C++
  In-Reply-To: <adeQc3I/[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox