public inbox for [email protected]  
help / color / mirror / Atom feed
From: Nathan Bossart <[email protected]>
To: CharSyam <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] Use cached hash to skip unnecessary key comparisons in dshash
Date: Fri, 10 Apr 2026 13:10:42 -0500
Message-ID: <adk9IiZYGam6OltO@nathan> (raw)
In-Reply-To: <adk8Z0HGDaXSRIgF@nathan>
References: <CAMrLSE4JrhPB2XYMOMzbPSsgE+6kmDaKHKiF34NWdnbQts=Cpw@mail.gmail.com>
	<adk8Z0HGDaXSRIgF@nathan>

On Sat, Apr 11, 2026 at 01:09:33AM +0900, CharSyam wrote:
> I believe this patch is ready for review.  I look forward to any feedback
> and am happy to make revisions.

Sorry, I forgot to ask whether we could move the "pre-check" to within the
equal_keys() function so that it needn't be added to every one of its
callers.

-- 
nathan





view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Use cached hash to skip unnecessary key comparisons in dshash
  In-Reply-To: <adk9IiZYGam6OltO@nathan>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox