public inbox for [email protected]  

help / color / mirror / Atom feed

From: Michael Paquier <[email protected]>
To: DaeMyung Kang <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] Use direct hash lookup in logicalrep_partmap_invalidate_cb()
Date: Sat, 18 Apr 2026 06:35:54 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

On Sat, Apr 18, 2026 at 02:44:50AM +0900, DaeMyung Kang wrote:
> LogicalRepPartMap is keyed by the partition's OID, which is assigned
> to entry->relmapentry.localreloid when the entry is populated in
> logicalrep_partition_open().  The invalidation callback therefore
> does not need to iterate over every entry to find the one matching
> the invalidated relation OID; a single hash_search(HASH_FIND) on
> reloid suffices.

At this stage of the release cycle (aka feature freeze is in effect as
of v19), I'd recommend that you add this patch to the next commit
fest, so as this could be considered for v20, whose development should
begin next July.  See [1].

[1]: https://commitfest.postgresql.org/59/
--
Michael


Attachments:

  [application/pgp-signature] signature.asc (833B, 2-signature.asc)
  download

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Use direct hash lookup in logicalrep_partmap_invalidate_cb()
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox