public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Sami Imseih <[email protected]>
Cc: Haibo Yan <[email protected]>
Cc: Mohamed ALi <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] Fix: Partitioned parent index remains invalid after child indexes are repaired
Date: Mon, 20 Apr 2026 07:07:59 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAA5RZ0uM7_YPdSahGh1sGeewMb9SzKswyLaZty8aR+a7XpQydQ@mail.gmail.com>
References: <CAGnOmWqi1D9ycBgUeOGf6mOCd2Dcf=6sKhbf4sHLs5xAcKVCMQ@mail.gmail.com>
<CABXr29GbJe7-vbm0Fn=HWx3vQonwFtv_zO1pSc5FZAvjLuUDVA@mail.gmail.com>
<CABXr29Epj=23eYAWg_mTdiXYQQzJSVN22uk6tK8ei0ts5wXvSQ@mail.gmail.com>
<CAA5RZ0s16eHrzcDupipAxC++e-p_n_M7Fpg-MG-V59fB=wykLw@mail.gmail.com>
<[email protected]>
<[email protected]>
<CAA5RZ0uM7_YPdSahGh1sGeewMb9SzKswyLaZty8aR+a7XpQydQ@mail.gmail.com>
On Sat, Apr 18, 2026 at 09:37:48AM -0500, Sami Imseih wrote:
> Here is the patch with tests. It adds a test for this case using
> multi-level partitions and ensures that the parent indexes are
> validated once a child index is set to valid. Also, I added the
> negative case where only one child index is validated to ensure
> that the parent indexes remain invalid.
That looks sensible here, including the test coverage. Thanks for the
patch!
One thing that I'm tempted to add is more scans to check indisvalid
across these commands, particularly after the individual ATTACH
PARTITION bits on each individual index.
A second thing. Do you think that it would be worth adding a
partitioned table that has no leaves in some portion of the test? I
was thinking about a partitioned table called idxpart2 attached to
idxpart in the first part of the test. I've found this pattern
usually useful for this area of the code when recursing with
validatePartitionedIndex() from a parent. I was also thinking about
a partitioned table idxpart3 in the last test block, but as you want
to check that indisvalid is not flipped to true for the parent if a
child is !indisvalid, it would not be adapted.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, 2-signature.asc)
download
view thread (12+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: [PATCH] Fix: Partitioned parent index remains invalid after child indexes are repaired
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox