public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Tom Lane <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: some extra warnings from MSVC
Date: Mon, 20 Apr 2026 07:18:37 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<[email protected]>
On Sat, Apr 11, 2026 at 10:09:58AM -0400, Tom Lane wrote:
> I think it'd be a good idea to warn even if we can't make gcc do that.
> I think Windows is the only 64-bit platform we deal with where long
> is just 32 bits, so covering the case in MSVC will expose bugs we
> would not notice otherwise.
Interesting issue. I did not notice this thread until 9018c7d37bb4.
Please do not hesitate to add me in CC in the future, as 13b935cd521
has my fingerprints. Thanks for fixing the issue.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, 2-signature.asc)
download
view thread (3+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: some extra warnings from MSVC
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox