public inbox for [email protected]help / color / mirror / Atom feed
Typo Fixes and Patch 3+ messages / 3 participants [nested] [flat]
* Typo Fixes and Patch @ 2026-04-16 00:22 Abhi Kaki <[email protected]> 0 siblings, 1 reply; 3+ messages in thread From: Abhi Kaki @ 2026-04-16 00:22 UTC (permalink / raw) To: [email protected] Hi Hackers, Fixed a couple of typo errors in the graph table and attached a patch. Please review. Regards, Abhi Attachments: [application/octet-stream] fix_typos_pgpa.patch (1.5K, 3-fix_typos_pgpa.patch) download | inline diff: diff --git a/contrib/pg_plan_advice/pgpa_join.c b/contrib/pg_plan_advice/pgpa_join.c index 38e7b91ed7e..067321081e7 100644 --- a/contrib/pg_plan_advice/pgpa_join.c +++ b/contrib/pg_plan_advice/pgpa_join.c @@ -93,7 +93,7 @@ pgpa_create_join_unroller(void) * * pgpa_plan_walker creates a "top level" join unroller object when it * encounters a join in a portion of the plan tree in which no join unroller - * is already active. From there, this function is responsible for determing + * is already active. From there, this function is responsible for determining * to what portion of the plan tree that join unroller applies, and for * creating any subordinate join unroller objects that are needed as a result * of non-outer-deep join trees. We do this by returning the join unroller diff --git a/contrib/pg_plan_advice/pgpa_output.c b/contrib/pg_plan_advice/pgpa_output.c index ed5a9340671..dd3ba692a86 100644 --- a/contrib/pg_plan_advice/pgpa_output.c +++ b/contrib/pg_plan_advice/pgpa_output.c @@ -114,7 +114,7 @@ pgpa_output_advice(StringInfo buf, pgpa_plan_walker_context *walker, context.wrap_column = 76; /* - * Each piece of JOIN_ORDER() advice fully describes the join order for a + * Each piece of JOIN_ORDER() advice fully describes the join order for * a single unrolled join. Merging is not permitted, because that would * change the meaning, e.g. SEQ_SCAN(a b c d) means simply that sequential * scans should be used for all of those relations, and is thus equivalent ^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Typo Fixes and Patch @ 2026-04-20 10:24 Ashutosh Bapat <[email protected]> parent: Abhi Kaki <[email protected]> 0 siblings, 1 reply; 3+ messages in thread From: Ashutosh Bapat @ 2026-04-20 10:24 UTC (permalink / raw) To: Abhi Kaki <[email protected]>; +Cc: [email protected] Hi Abhi, On Sat, Apr 18, 2026 at 11:49 AM Abhi Kaki <[email protected]> wrote: > > Hi Hackers, > > Fixed a couple of typo errors in the graph table and attached a patch. > Please review. I don't see any graph table related typo fixes in the patch. Maybe you attached a wrong patch? The fixes in pg_plan_advice related code look good. -- Best Wishes, Ashutosh Bapat ^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Typo Fixes and Patch @ 2026-04-21 04:17 Michael Paquier <[email protected]> parent: Ashutosh Bapat <[email protected]> 0 siblings, 0 replies; 3+ messages in thread From: Michael Paquier @ 2026-04-21 04:17 UTC (permalink / raw) To: Ashutosh Bapat <[email protected]>; +Cc: Abhi Kaki <[email protected]>; [email protected] On Mon, Apr 20, 2026 at 03:54:12PM +0530, Ashutosh Bapat wrote: > I don't see any graph table related typo fixes in the patch. Maybe you > attached a wrong patch? That would be nice, yes. > The fixes in pg_plan_advice related code look good. Yep. I have a batch that I am planning to merge into the tree soonish-ly, and these are now included. Thanks. -- Michael Attachments: [application/pgp-signature] signature.asc (833B, 2-signature.asc) download ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2026-04-21 04:17 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-04-16 00:22 Typo Fixes and Patch Abhi Kaki <[email protected]> 2026-04-20 10:24 ` Ashutosh Bapat <[email protected]> 2026-04-21 04:17 ` Michael Paquier <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox