public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Heikki Linnakangas <[email protected]>
Cc: Tristan Partin <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: Add editorconfig support for Postgres spec files
Date: Tue, 21 Apr 2026 14:43:06 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<[email protected]>
On Fri, Apr 17, 2026 at 11:18:22AM +0300, Heikki Linnakangas wrote:
> src/test/isolation/specs/nowait.spec: indented with 2 spaces. But there are
> some tabs too.
>
> src/test/modules/injection_points/specs/repack_toast.spec: Tabs
>
> src/test/modules/brin/specs/summarization-and-inprogress-insertion.spec: Mix
> of tabs and spaces, width 4.
>
> Yeah, it would be nice to standardize on something...
In terms of system_views.sql, the SQL input files in the regression
test suites and the sample files, we are using whitespaces, not tabs.
I cannot say much about the width part and what would be a good
number, but at least it seems to me that the tabs should go. We don't
really have a strict width rule for the SQL files in the regression
tests, and I don't think we need one. It would be nice to keep the
same flexibility for the isolation spec files.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, 2-signature.asc)
download
view thread (5+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: Add editorconfig support for Postgres spec files
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox