From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
To: Jamison, Kirk <k.jamison@jp.fujitsu.com>
Cc: 'jesper.pedersen@redhat.com' <jesper.pedersen@redhat.com>
Cc: pgsql-hackers@lists.postgresql.org <pgsql-hackers@lists.postgresql.org>
Cc: Bruce Momjian <bruce@momjian.us>
Subject: Re: pg_upgrade: Pass -j down to vacuumdb
Date: Fri, 25 Jan 2019 13:00:55 +0100
Message-ID: <aeea26f9-f42b-8570-9ee1-304c4f33281b@2ndquadrant.com> (raw)
In-Reply-To: <20190125102859.GD6459@paquier.xyz>
References: <11b6b108-6ac0-79a6-785a-f13dfe60ab92@redhat.com>
<ba90295e-9734-07bc-3453-bfa878948478@2ndquadrant.com>
<2dc5eaeb-e60d-2a16-696e-7b4d3d3548cb@redhat.com>
<59f9323a-fee8-88f6-16ab-2319149b00be@2ndquadrant.com>
<5b7d95ba-8920-357d-1ec6-1084ce34a9e6@redhat.com>
<D09B13F772D2274BB348A310EE3027C64137E4@g01jpexmbkw24>
<20190125102859.GD6459@paquier.xyz>
On 25/01/2019 11:28, Michael Paquier wrote:
> based on that linking the value used by pg_upgrade and vacuumdb is a
> bad concept in my opinion, and the patch should be rejected. More
> documentation on pg_upgrade side to explain that a bit better could be
> a good idea though, as it is perfectly possible to use your own
> post-upgrade script or rewrite partially the generated one.
Right. pg_upgrade doesn't actually call vacuumdb. It creates a script
that you may use. The script itself contains a comment that says, if
you want to do this as fast as possible, don't use this script. That
comment could be enhanced to suggest the use of the -j option.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, michael@paquier.xyz, k.jamison@jp.fujitsu.com, jesper.pedersen@redhat.com, pgsql-hackers@lists.postgresql.org, bruce@momjian.us
Subject: Re: pg_upgrade: Pass -j down to vacuumdb
In-Reply-To: <aeea26f9-f42b-8570-9ee1-304c4f33281b@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox