pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feed[Code Comments]enum COPY_NEW_FE is removed
3+ messages / 2 participants
[nested] [flat]
Commits from this thread:
2022-08-06 70d25bf70c Fix comment in copyfrom_internal.h
* [Code Comments]enum COPY_NEW_FE is removed
@ 2022-08-06 11:20 Zhang Mingli <zmlpostgres@gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Zhang Mingli @ 2022-08-06 11:20 UTC (permalink / raw)
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Hi,
Enum COPY_NEW_FE is removed in commit 3174d69fb9.
Should use COPY_FRONTEND instead.
Issue exists on 15 and master.
```
typedef struct CopyFromStateData
- StringInfo fe_msgbuf; /* used if copy_src == COPY_NEW_FE */
+ StringInfo fe_msgbuf; /* used if copy_src == COPY_FRONTEND */
```
Regards,
Zhang Mingli
Attachments:
v-0001-Fix-code-comments-COPY_FRONTEND.patch (application/octet-stream, 1.1K) download
From 5da5282cc29e45bda35a6e29ad8f87d6745f4856 Mon Sep 17 00:00:00 2001
From: Mingli Zhang <avamingli@gmail.com>
Date: Sat, 6 Aug 2022 19:08:42 +0800
Subject: [PATCH vn] Fix code comments COPY_FRONTEND
COPY_NEW_FE is removed in commit 3174d69fb9.
Use COPY_FRONTEND instead.
Backpatch-through: 15
Discussion: xxx
Reviewed-by: xxx
---
src/include/commands/copyfrom_internal.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/include/commands/copyfrom_internal.h b/src/include/commands/copyfrom_internal.h
index 3df1c5a97c..e37c6032ae 100644
--- a/src/include/commands/copyfrom_internal.h
+++ b/src/include/commands/copyfrom_internal.h
@@ -58,7 +58,7 @@ typedef struct CopyFromStateData
/* low-level state data */
CopySource copy_src; /* type of copy source */
FILE *copy_file; /* used if copy_src == COPY_FILE */
- StringInfo fe_msgbuf; /* used if copy_src == COPY_NEW_FE */
+ StringInfo fe_msgbuf; /* used if copy_src == COPY_FRONTEND */
EolType eol_type; /* EOL type of input */
int file_encoding; /* file or remote side's character encoding */
--
2.34.1
* Re: [Code Comments]enum COPY_NEW_FE is removed
@ 2022-08-06 12:17 Michael Paquier <michael@paquier.xyz>
parent: Zhang Mingli <zmlpostgres@gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Michael Paquier @ 2022-08-06 12:17 UTC (permalink / raw)
To: Zhang Mingli <zmlpostgres@gmail.com>; +Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Sat, Aug 06, 2022 at 07:20:25PM +0800, Zhang Mingli wrote:
> Enum COPY_NEW_FE is removed in commit 3174d69fb9.
>
> Should use COPY_FRONTEND instead.
>
> Issue exists on 15 and master.
This also exists in REL_14_STABLE. I have fixed that on HEAD, as
that's just a comment.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: [Code Comments]enum COPY_NEW_FE is removed
@ 2022-08-06 13:01 Zhang Mingli <zmlpostgres@gmail.com>
parent: Michael Paquier <michael@paquier.xyz>
0 siblings, 0 replies; 3+ messages in thread
From: Zhang Mingli @ 2022-08-06 13:01 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; +Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Ok, thanks.
Michael Paquier <michael@paquier.xyz>于2022年8月6日 周六20:17写道：
> On Sat, Aug 06, 2022 at 07:20:25PM +0800, Zhang Mingli wrote:
> > Enum COPY_NEW_FE is removed in commit 3174d69fb9.
> >
> > Should use COPY_FRONTEND instead.
> >
> > Issue exists on 15 and master.
>
> This also exists in REL_14_STABLE. I have fixed that on HEAD, as
> that's just a comment.
> --
> Michael
>
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2022-08-06 13:01 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-08-06 11:20 [Code Comments]enum COPY_NEW_FE is removed Zhang Mingli <zmlpostgres@gmail.com>
2022-08-06 12:17 ` Michael Paquier <michael@paquier.xyz>
2022-08-06 13:01 ` Zhang Mingli <zmlpostgres@gmail.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox