public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Andres Freund <[email protected]>
Cc: Fujii Masao <[email protected]>
Cc: Chao Li <[email protected]>
Cc: Henrik TJ <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Fix memory leak in postmasterMain
Date: Thu, 23 Apr 2026 16:44:06 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <mwikkx643zp3f5qmx27crf2d2ngwgupc4om4kfq4gyc6vukjom@kyimpnconhdv>
References: <[email protected]>
<[email protected]>
<[email protected]>
<CAHGQGwEn3oEad-wR1XoEbe1R-pB1EOycRKjEj+5Pp38mjgiF+Q@mail.gmail.com>
<mwikkx643zp3f5qmx27crf2d2ngwgupc4om4kfq4gyc6vukjom@kyimpnconhdv>
On Wed, Apr 22, 2026 at 01:55:36PM -0400, Andres Freund wrote:
> If we do it, we should actually be a bit more systematic and also free
> output_config_variable.
>
> ISTM those strdup()s should actually be pstrdup()s? I suspect changing that
> would also silence valgrind.
I don't see immediately why it would not be OK to maintain this data
in the postmaster context. There is no need to rush this change on
HEAD, IMO, I'd suggest to leave that as a v20 item..
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, 2-signature.asc)
download
view thread (7+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Fix memory leak in postmasterMain
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox