public inbox for [email protected]
help / color / mirror / Atom feedFrom: Nathan Bossart <[email protected]>
To: Tom Lane <[email protected]>
Cc: [email protected]
Subject: Re: small cleanup for s_lock.h
Date: Thu, 7 May 2026 16:28:09 -0500
Message-ID: <af0D6fhLfVmG2fr7@nathan> (raw)
In-Reply-To: <af0AKUfzjGDvQdBk@nathan>
References: <afkUeI7UhacZ5ZFm@nathan>
<[email protected]>
<afoWBgsygtkCNCRQ@nathan>
<[email protected]>
<afovdi61nybDRbC3@nathan>
<afz5FHWr6rOB7bsL@nathan>
<af0AKUfzjGDvQdBk@nathan>
On Thu, May 07, 2026 at 04:12:09PM -0500, Nathan Bossart wrote:
> On Thu, May 07, 2026 at 03:41:56PM -0500, Nathan Bossart wrote:
>> +/*
>> + * We can only define TAS_SPIN if TAS was defined. Otherwise, the platform
>> + * defined its own S_LOCK without TAS, and therefore is responsible for
>> + * defining its own TAS_SPIN as well. (Note that we currently do not have any
>> + * platforms that don't define TAS.)
>> + */
>> #if !defined(TAS_SPIN)
>> +#if defined(TAS)
>> #define TAS_SPIN(lock) TAS(lock)
>> -#endif /* TAS_SPIN */
>> +#else
>> +#error Neither TAS nor TAS_SPIN defined on this platform. Please report this to [email protected].
>> +#endif /* TAS */
>> +#endif /* ! TAS_SPIN */
>
> Wait, this isn't right. TAS_SPIN is only used by s_lock(), which is only
> used by the default S_LOCK. We should just not compile s_lock() if the
> platform defines its own S_LOCK, and we shouldn't #error here if TAS is not
> defined.
Should be fixed in v5, sorry for the noise.
--
nathan
view thread (12+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected]
Subject: Re: small cleanup for s_lock.h
In-Reply-To: <af0D6fhLfVmG2fr7@nathan>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox