pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Heikki Linnakangas <hlinnaka@iki.fi>
To: John Naylor <john.naylor@enterprisedb.com>
Cc: Jaime Casanova <jcasanov@systemguards.com.ec>
Cc: vignesh C <vignesh21@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Zhihong Yu <zyu@yugabyte.com>
Subject: Re: Polyphase merge is obsolete
Date: Sat, 19 Nov 2022 12:00:12 +0100
Message-ID: <af989685-91d5-aad4-8f60-1d066b5ec309@enterprisedb.com> (raw)
In-Reply-To: <882e7ef2-ae13-d085-c2e8-0b75b931f7b7@iki.fi>
References: <420a0ec7-602c-d406-1e75-1ef7ddc58d83@iki.fi>
	<264a0544-c4e9-315e-18fa-1afd9151e939@2ndquadrant.com>
	<6a15881f-0cc5-3564-abc0-03ec28883380@iki.fi>
	<4c6a8fd7-1902-fc8e-e8d6-281d426f5da8@iki.fi>
	<CALDaNm3K8iZh7zGKrSNHb4crGRdn3LsudgtEa=+Oz4LQE0SJOQ@mail.gmail.com>
	<91284957-3cb2-944e-5f14-5c2ff86b49fa@iki.fi>
	<20210911063527.GB3770@ahch-to>
	<20210915211253.GA17635@ahch-to>
	<565b8856-2e64-b892-e44c-969bae6c0400@iki.fi>
	<CAFBsxsEbWy=imDgm_HpQg2r98p5GnKBR0pkv4xBBbSNTNM8fRQ@mail.gmail.com>
	<882e7ef2-ae13-d085-c2e8-0b75b931f7b7@iki.fi>

On 18.10.21 14:15, Heikki Linnakangas wrote:
> On 05/10/2021 20:24, John Naylor wrote:
>> I've had a chance to review and test out the v5 patches.
> 
> Thanks! I fixed the stray reference to PostgreSQL 14 that Zhihong 
> mentioned, and pushed.

AFAICT, this thread updated the API of LogicalTapeSetCreate() in PG15, 
but did not adequately update the function header comment.  The comment 
still mentions the "shared" argument, which has been removed.  There is 
a new "preallocate" argument that is not mentioned at all.  Also, it's 
not easy to match the actual callers to the call variants described in 
the comment.  Could someone who remembers this work perhaps look this 
over and update the comment?






view thread (28+ messages)  latest in thread

Message-ID: <af989685-91d5-aad4-8f60-1d066b5ec309@enterprisedb.com>
Permalink:  ../af989685-91d5-aad4-8f60-1d066b5ec309@enterprisedb.com/
Also on:    postgresql.org/message-id/af989685-91d5-aad4-8f60-1d066b5ec309@enterprisedb.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@enterprisedb.com, hlinnaka@iki.fi, john.naylor@enterprisedb.com, jcasanov@systemguards.com.ec, vignesh21@gmail.com, pg@bowt.ie, tomas.vondra@2ndquadrant.com, zyu@yugabyte.com
  Subject: Re: Polyphase merge is obsolete
  In-Reply-To: <af989685-91d5-aad4-8f60-1d066b5ec309@enterprisedb.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox