Fix the error hint message and test for reset_shared with unknown stats type

public inbox for [email protected]  
help / color / mirror / Atom feed

Fix the error hint message and test for reset_shared with unknown stats type
4+ messages / 2 participants
[nested] [flat]

* Fix the error hint message and test for reset_shared with unknown stats type
@ 2026-04-28 15:13  Maksim Logvinenko <[email protected]>
  0 siblings, 1 reply; 4+ messages in thread

From: Maksim Logvinenko @ 2026-04-28 15:13 UTC (permalink / raw)
  To: [email protected] <[email protected]>

<div><div><div>Hi hackers,</div><div> </div><div>The errhint() in pg_stat_reset_shared() were missing the fact that recently added in [1] new lock stats kind.</div><div>The patch fixes error hint message and regress test for reset_shared with unknown stats type.</div><div> </div><div>[1]: https://www.postgresql.org/message-id/aIyNxBWFCybgBZBS%40ip-10-97-1-34.eu-west-3.compute.internal<... regards,</div><div>Maksim Logvinenko</div><div>Postgres Professional: http://postgrespro.com</div></div></div;

^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: Fix the error hint message and test for reset_shared with unknown stats type
@ 2026-04-28 15:18  Maksim Logvinenko <[email protected]>
  parent: Maksim Logvinenko <[email protected]>
  0 siblings, 1 reply; 4+ messages in thread

From: Maksim Logvinenko @ 2026-04-28 15:18 UTC (permalink / raw)
  To: [email protected] <[email protected]>


------==--bound.584528.0fb4da4d-3380-491c-8906-9d1c93362c27
Content-Transfer-Encoding: base64
Content-Type: text/html; charset=utf-8

PGRpdj7CoDwvZGl2PjxkaXY+PGRpdj48c3BhbiBzdHlsZT0id2hpdGUtc3BhY2U6cHJlLXdyYXAi
PkknbSBzb3JyeSBmb3IgdGhlIGZvcmdvdHRlbiBwYXRjaCBpbiB0aGUgYXR0YWNobWVudDwvc3Bh
bj48L2Rpdj48L2Rpdj48ZGl2Pi0tLS0tLS0tLS0tLS0tLS08L2Rpdj48ZGl2PtCa0L7QvNGDOiBw
Z3NxbC1oYWNrZXJzQGxpc3RzLnBvc3RncmVzcWwub3JnIChwZ3NxbC1oYWNrZXJzQGxpc3RzLnBv
c3RncmVzcWwub3JnKTs8L2Rpdj48ZGl2PtCi0LXQvNCwOiBGaXggdGhlIGVycm9yIGhpbnQgbWVz
c2FnZSBhbmQgdGVzdCBmb3IgcmVzZXRfc2hhcmVkIHdpdGggdW5rbm93biBzdGF0cyB0eXBlOzwv
ZGl2PjxkaXY+MjguMDQuMjAyNiwgMjA6MTMsICJNYWtzaW0gTG9ndmluZW5rbyIgJmx0O2xvZ3Zp
bmVua28tbXNAeWFuZGV4LnJ1Jmd0Ozo8L2Rpdj48YmxvY2txdW90ZT48ZGl2PjxkaXY+PGRpdj5I
aSBoYWNrZXJzLDwvZGl2PjxkaXY+wqA8L2Rpdj48ZGl2PlRoZSBlcnJoaW50KCkgaW4gcGdfc3Rh
dF9yZXNldF9zaGFyZWQoKSB3ZXJlIG1pc3NpbmcgdGhlIGZhY3QgdGhhdCByZWNlbnRseSBhZGRl
ZCBpbiBbMV0gbmV3IGxvY2sgc3RhdHMga2luZC48L2Rpdj48ZGl2PlRoZSBwYXRjaCBmaXhlcyBl
cnJvciBoaW50IG1lc3NhZ2UgYW5kIHJlZ3Jlc3MgdGVzdCBmb3IgcmVzZXRfc2hhcmVkIHdpdGgg
dW5rbm93biBzdGF0cyB0eXBlLjwvZGl2PjxkaXY+wqA8L2Rpdj48ZGl2PlsxXTogPGEgaHJlZj0i
aHR0cHM6Ly93d3cucG9zdGdyZXNxbC5vcmcvbWVzc2FnZS1pZC9hSXlOeEJXRkN5YmdCWkJTJTQw
aXAtMTAtOTctMS0zNC5ldS13ZXN0LTMuY29tcHV0ZS5pbnRlcm5hbCIgcmVsPSJub29wZW5lciBu
b3JlZmVycmVyIj5odHRwczovL3d3dy5wb3N0Z3Jlc3FsLm9yZy9tZXNzYWdlLWlkL2FJeU54QldG
Q3liZ0JaQlMlNDBpcC0xMC05Ny0xLTM0LmV1LXdlc3QtMy5jb21wdXRlLmludGVybmFsPC9hPjwv
ZGl2PjxkaXY+wqA8L2Rpdj48ZGl2PkJlc3QgcmVnYXJkcyw8L2Rpdj48ZGl2Pk1ha3NpbSBMb2d2
aW5lbmtvPC9kaXY+PGRpdj5Qb3N0Z3JlcyBQcm9mZXNzaW9uYWw6IDxhIGhyZWY9Imh0dHA6Ly9w
b3N0Z3Jlc3Byby5jb20vIiByZWw9Im5vb3BlbmVyIG5vcmVmZXJyZXIiPmh0dHA6Ly9wb3N0Z3Jl
c3Byby5jb208L2E+PC9kaXY+PC9kaXY+PC9kaXY+PC9ibG9ja3F1b3RlPg==
------==--bound.584528.0fb4da4d-3380-491c-8906-9d1c93362c27
Content-Disposition: attachment;
	filename="0001-Fix-the-error-hint-message-and-test-for-reset_shared.patch"
Content-Transfer-Encoding: base64
Content-Type: text/x-diff;
	name="0001-Fix-the-error-hint-message-and-test-for-reset_shared.patch"

RnJvbSA3MDE0NmQwYzdmZTQ0Mzg2ODdmYjU0NjljNjBiNGZlYmJmNDBjYWMwIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBNYWtzaW0gTG9ndmluZW5rbyA8bG9ndmluZW5rby1tc0B5YW5k
ZXgucnU+CkRhdGU6IFR1ZSwgMjggQXByIDIwMjYgMjA6MDY6NDUgKzA1MDAKU3ViamVjdDogW1BB
VENIXSBGaXggdGhlIGVycm9yIGhpbnQgbWVzc2FnZSBhbmQgdGVzdCBmb3IgcmVzZXRfc2hhcmVk
IHdpdGgKIHVua25vd24gc3RhdHMgdHlwZS4KClRoZSBleGlzdGluZyBlcnJvciBoaW50IG1lc3Nh
Z2UgYW5kIHRlc3Qgd2VyZSBtaXNzaW5nIHRoZSBmYWN0IHRoYXQKcmVjZW50bHkgYWRkZWQgbmV3
IGxvY2sgc3RhdHMga2luZC4KLS0tCiBzcmMvYmFja2VuZC91dGlscy9hZHQvcGdzdGF0ZnVuY3Mu
YyB8IDIgKy0KIHNyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvc3RhdHMub3V0IHwgMiArLQogMiBm
aWxlcyBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0
IGEvc3JjL2JhY2tlbmQvdXRpbHMvYWR0L3Bnc3RhdGZ1bmNzLmMgYi9zcmMvYmFja2VuZC91dGls
cy9hZHQvcGdzdGF0ZnVuY3MuYwppbmRleCAxNDA4ZGUzODdlYS4uN2E5ZGZhOWJhM2IgMTAwNjQ0
Ci0tLSBhL3NyYy9iYWNrZW5kL3V0aWxzL2FkdC9wZ3N0YXRmdW5jcy5jCisrKyBiL3NyYy9iYWNr
ZW5kL3V0aWxzL2FkdC9wZ3N0YXRmdW5jcy5jCkBAIC0xOTg3LDcgKzE5ODcsNyBAQCBwZ19zdGF0
X3Jlc2V0X3NoYXJlZChQR19GVU5DVElPTl9BUkdTKQogCQllcmVwb3J0KEVSUk9SLAogCQkJCShl
cnJjb2RlKEVSUkNPREVfSU5WQUxJRF9QQVJBTUVURVJfVkFMVUUpLAogCQkJCSBlcnJtc2coInVu
cmVjb2duaXplZCByZXNldCB0YXJnZXQ6IFwiJXNcIiIsIHRhcmdldCksCi0JCQkJIGVycmhpbnQo
IlRhcmdldCBtdXN0IGJlIFwiYXJjaGl2ZXJcIiwgXCJiZ3dyaXRlclwiLCBcImNoZWNrcG9pbnRl
clwiLCBcImlvXCIsIFwicmVjb3ZlcnlfcHJlZmV0Y2hcIiwgXCJzbHJ1XCIsIG9yIFwid2FsXCIu
IikpKTsKKwkJCQkgZXJyaGludCgiVGFyZ2V0IG11c3QgYmUgXCJhcmNoaXZlclwiLCBcImJnd3Jp
dGVyXCIsIFwiY2hlY2twb2ludGVyXCIsIFwiaW9cIiwgXCJsb2NrXCIsIFwicmVjb3ZlcnlfcHJl
ZmV0Y2hcIiwgXCJzbHJ1XCIsIG9yIFwid2FsXCIuIikpKTsKIAogCVBHX1JFVFVSTl9WT0lEKCk7
CiB9CmRpZmYgLS1naXQgYS9zcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL3N0YXRzLm91dCBiL3Ny
Yy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvc3RhdHMub3V0CmluZGV4IGU1ZGNiODVhYmQ4Li5jNTUx
YWJiMTE3OCAxMDA2NDQKLS0tIGEvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9zdGF0cy5vdXQK
KysrIGIvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9zdGF0cy5vdXQKQEAgLTExNjQsNyArMTE2
NCw3IEBAIFNFTEVDVCBzdGF0c19yZXNldCA+IDond2FsX3Jlc2V0X3RzJzo6dGltZXN0YW1wdHog
RlJPTSBwZ19zdGF0X3dhbDsKIC0tIFRlc3QgZXJyb3IgY2FzZSBmb3IgcmVzZXRfc2hhcmVkIHdp
dGggdW5rbm93biBzdGF0cyB0eXBlCiBTRUxFQ1QgcGdfc3RhdF9yZXNldF9zaGFyZWQoJ3Vua25v
d24nKTsKIEVSUk9SOiAgdW5yZWNvZ25pemVkIHJlc2V0IHRhcmdldDogInVua25vd24iCi1ISU5U
OiAgVGFyZ2V0IG11c3QgYmUgImFyY2hpdmVyIiwgImJnd3JpdGVyIiwgImNoZWNrcG9pbnRlciIs
ICJpbyIsICJyZWNvdmVyeV9wcmVmZXRjaCIsICJzbHJ1Iiwgb3IgIndhbCIuCitISU5UOiAgVGFy
Z2V0IG11c3QgYmUgImFyY2hpdmVyIiwgImJnd3JpdGVyIiwgImNoZWNrcG9pbnRlciIsICJpbyIs
ICJsb2NrIiwgInJlY292ZXJ5X3ByZWZldGNoIiwgInNscnUiLCBvciAid2FsIi4KIC0tIFRlc3Qg
dGhhdCByZXNldCB3b3JrcyBmb3IgcGdfc3RhdF9kYXRhYmFzZSBhbmQgcGdfc3RhdF9kYXRhYmFz
ZV9jb25mbGljdHMKIC0tIFNpbmNlIHBnX3N0YXRfZGF0YWJhc2Ugc3RhdHNfcmVzZXQgc3RhcnRz
IG91dCBhcyBOVUxMLCByZXNldCBpdCBvbmNlIGZpcnN0IHNvIHRoYXQgd2UKIC0tIGhhdmUgYSBi
YXNlbGluZSBmb3IgY29tcGFyaXNvbi4gVGhlIHNhbWUgZm9yIHBnX3N0YXRfZGF0YWJhc2VfY29u
ZmxpY3RzIGFzIGl0IHNoYXJlcwotLSAKMi40My4wCgo=
------==--bound.584528.0fb4da4d-3380-491c-8906-9d1c93362c27--





Attachments:

  [text/x-diff] 0001-Fix-the-error-hint-message-and-test-for-reset_shared.patch (2.1K, 2-0001-Fix-the-error-hint-message-and-test-for-reset_shared.patch)
  download | inline diff:
From 70146d0c7fe4438687fb5469c60b4febbf40cac0 Mon Sep 17 00:00:00 2001
From: Maksim Logvinenko <[email protected]>
Date: Tue, 28 Apr 2026 20:06:45 +0500
Subject: [PATCH] Fix the error hint message and test for reset_shared with
 unknown stats type.

The existing error hint message and test were missing the fact that
recently added new lock stats kind.
---
 src/backend/utils/adt/pgstatfuncs.c | 2 +-
 src/test/regress/expected/stats.out | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/backend/utils/adt/pgstatfuncs.c b/src/backend/utils/adt/pgstatfuncs.c
index 1408de387ea..7a9dfa9ba3b 100644
--- a/src/backend/utils/adt/pgstatfuncs.c
+++ b/src/backend/utils/adt/pgstatfuncs.c
@@ -1987,7 +1987,7 @@ pg_stat_reset_shared(PG_FUNCTION_ARGS)
 		ereport(ERROR,
 				(errcode(ERRCODE_INVALID_PARAMETER_VALUE),
 				 errmsg("unrecognized reset target: \"%s\"", target),
-				 errhint("Target must be \"archiver\", \"bgwriter\", \"checkpointer\", \"io\", \"recovery_prefetch\", \"slru\", or \"wal\".")));
+				 errhint("Target must be \"archiver\", \"bgwriter\", \"checkpointer\", \"io\", \"lock\", \"recovery_prefetch\", \"slru\", or \"wal\".")));
 
 	PG_RETURN_VOID();
 }
diff --git a/src/test/regress/expected/stats.out b/src/test/regress/expected/stats.out
index e5dcb85abd8..c551abb1178 100644
--- a/src/test/regress/expected/stats.out
+++ b/src/test/regress/expected/stats.out
@@ -1164,7 +1164,7 @@ SELECT stats_reset > :'wal_reset_ts'::timestamptz FROM pg_stat_wal;
 -- Test error case for reset_shared with unknown stats type
 SELECT pg_stat_reset_shared('unknown');
 ERROR:  unrecognized reset target: "unknown"
-HINT:  Target must be "archiver", "bgwriter", "checkpointer", "io", "recovery_prefetch", "slru", or "wal".
+HINT:  Target must be "archiver", "bgwriter", "checkpointer", "io", "lock", "recovery_prefetch", "slru", or "wal".
 -- Test that reset works for pg_stat_database and pg_stat_database_conflicts
 -- Since pg_stat_database stats_reset starts out as NULL, reset it once first so that we
 -- have a baseline for comparison. The same for pg_stat_database_conflicts as it shares
-- 
2.43.0



^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: Fix the error hint message and test for reset_shared with unknown stats type
@ 2026-04-28 23:12  Michael Paquier <[email protected]>
  parent: Maksim Logvinenko <[email protected]>
  0 siblings, 1 reply; 4+ messages in thread

From: Michael Paquier @ 2026-04-28 23:12 UTC (permalink / raw)
  To: Maksim Logvinenko <[email protected]>; +Cc: [email protected] <[email protected]>

On Tue, Apr 28, 2026 at 08:18:21PM +0500, Maksim Logvinenko wrote:
> The existing error hint message and test were missing the fact that
> recently added new lock stats kind.
>
> @@ -1987,7 +1987,7 @@ pg_stat_reset_shared(PG_FUNCTION_ARGS)
>  		ereport(ERROR,
>  				(errcode(ERRCODE_INVALID_PARAMETER_VALUE),
>  				 errmsg("unrecognized reset target: \"%s\"", target),
> -				 errhint("Target must be \"archiver\", \"bgwriter\", \"checkpointer\", \"io\", \"recovery_prefetch\", \"slru\", or \"wal\".")));
> +				 errhint("Target must be \"archiver\", \"bgwriter\", \"checkpointer\", \"io\", \"lock\", \"recovery_prefetch\", \"slru\", or \"wal\".")));

Right, thanks for the report, Maksim.  I'll fix it later.
--
Michael


Attachments:

  [application/pgp-signature] signature.asc (833B, 2-signature.asc)
  download

^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: Fix the error hint message and test for reset_shared with unknown stats type
@ 2026-04-30 02:33  Michael Paquier <[email protected]>
  parent: Michael Paquier <[email protected]>
  0 siblings, 0 replies; 4+ messages in thread

From: Michael Paquier @ 2026-04-30 02:33 UTC (permalink / raw)
  To: Maksim Logvinenko <[email protected]>; +Cc: [email protected] <[email protected]>

On Wed, Apr 29, 2026 at 08:12:04AM +0900, Michael Paquier wrote:
> Right, thanks for the report, Maksim.  I'll fix it later.

And done.
--
Michael


Attachments:

  [application/pgp-signature] signature.asc (833B, 2-signature.asc)
  download

^ permalink  raw  reply  [nested|flat] 4+ messages in thread

end of thread, other threads:[~2026-04-30 02:33 UTC | newest]

Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-04-28 15:13 Fix the error hint message and test for reset_shared with unknown stats type Maksim Logvinenko <[email protected]>
2026-04-28 15:18 ` Maksim Logvinenko <[email protected]>
2026-04-28 23:12   ` Michael Paquier <[email protected]>
2026-04-30 02:33     ` Michael Paquier <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox