public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Peter Eisentraut <[email protected]>
Cc: Aleksander Alekseev <[email protected]>
Cc: pgsql-hackers <[email protected]>
Cc: Kirill Reshke <[email protected]>
Cc: David Rowley <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Heikki Linnakangas <[email protected]>
Cc: Nathan Bossart <[email protected]>
Cc: [email protected]
Subject: Re: Define DatumGetInt8 function.
Date: Thu, 30 Apr 2026 14:28:04 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CALdSSPg6UgK+6LJmFQ6G3av4J6dbngN7=QwQEuFZApnpmXgVWQ@mail.gmail.com>
<CAApHDvoShMiWPSkV8zE3tu7uo9GEmuoe=gTpM0+GfOFh2iDmmw@mail.gmail.com>
<CALdSSPjmukA1WGyYVqJMPD8080Rm9oXPVLn5T64xFCj6wKAenQ@mail.gmail.com>
<CAJ7c6TPsaLW7O67vqv8YyV_qUUjF0pncDB7dCQJFDw0so7wrdw@mail.gmail.com>
<CALdSSPjSaTvQL28csVo-8hNg8xJ5=YFr6qwtF=JAMLb1eJO2gQ@mail.gmail.com>
<CAJ7c6TM4zecvHj0F9Xk-V1gKqjYQOR4EjerTVkrZ18+w-6JN3Q@mail.gmail.com>
<[email protected]>
<CAJ7c6TMcGu8qmRe1gZfJ-gOzVnZq-t=fwn-UuyStx1w6ZyydMw@mail.gmail.com>
<[email protected]>
<[email protected]>
On Tue, Apr 28, 2026 at 02:13:31PM +0900, Michael Paquier wrote:
> In short, it took me some time to put some order into all that,
> finishing with the attached patch set. 0001 is the minimum for v19,
> that reverts 6dcfac9696cb so as we have more *GetDatum() matching with
> the types in the SQL functions. That would take care of the open item
> on top of my head.
This was not completely right after a second look. 6dcfac9696cb did
not get things completely wrong, either, the brin and gist parts of
the changes were right. I have undone the incorrect bits for now to
address the open item.
> 0002 is a set of fixes that I have spotted while investigating this
> set of issues in depth. These spots are actually wrong, some of them
> for a long time. I would be slightly tempted to do something about
> these in v19 rather than wait for v20, as these are somewhat latent
> bugs, to have more consistency across the board. Has anybody from the
> RMT an opinion to offer? There is not much urgency in it, still..
> Added the RMT in CC for opinions.
This deserves a different discussion, unrelated to DatumGetInt8().
I'll post that on a separate thread, for v20.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, 2-signature.asc)
download
view thread (10+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Define DatumGetInt8 function.
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox