public inbox for [email protected]
help / color / mirror / Atom feedFrom: 'Alvaro Herrera' <[email protected]>
To: Hayato Kuroda (Fujitsu) <[email protected]>
Cc: Mihail Nikalayeu <[email protected]>
Cc: Antonin Houska <[email protected]>
Cc: Srinath Reddy Sadipiralla <[email protected]>
Cc: Amit Kapila <[email protected]>
Cc: Matthias van de Meent <[email protected]>
Cc: Pg Hackers <[email protected]>
Cc: Robert Treat <[email protected]>
Subject: Re: Adding REPACK [concurrently]
Date: Fri, 1 May 2026 09:30:27 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <OS9PR01MB121498680B79ECB53367E269EF55AA@OS9PR01MB12149.jpnprd01.prod.outlook.com>
Hello,
On 2026-Apr-07, Hayato Kuroda (Fujitsu) wrote:
> 01.
> ```
> --- a/src/backend/access/index/genam.c
> +++ b/src/backend/access/index/genam.c
> @@ -394,6 +394,14 @@ systable_beginscan(Relation heapRelation,
> SysScanDesc sysscan;
> Relation irel;
>
> + /*
> + * If this backend promised that it won't access shared catalogs during
> + * logical decoding, this it the right place to verify.
> + */
> + Assert(!HistoricSnapshotActive() ||
> + accessSharedCatalogsInDecoding ||
> + !heapRelation->rd_rel->relisshared);
> ```
>
> Not sure it's OK to use Assert(). elog(ERROR) might be better if we want to really
> avoid the case.
How about the attached?
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Adding REPACK [concurrently]
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox