From: Alexander Lakhin <exclusion@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: make installcheck-world in a clean environment
Date: Fri, 4 May 2018 15:30:56 +0300
Message-ID: <aff02bd6-20c9-0b6e-4e3c-a3428ce6568b@gmail.com> (raw)
In-Reply-To: <CA+TgmoafXiYMj6ROd09PxLFQ_dpurP1FJOL4ZwDonCkPeSubWg@mail.gmail.com>
References: <bfee872b-ab16-ec7c-8f8a-b3949add1c1b@gmail.com>
<CA+TgmoafXiYMj6ROd09PxLFQ_dpurP1FJOL4ZwDonCkPeSubWg@mail.gmail.com>
04.05.2018 14:58, Robert Haas wrote:
Thanks for your involvement!
> Your proposed fix involves inventing something called
> USE_INSTALLED_ASSETS, but we don't need that anywhere else, so why do
> we need it for ECPG?
We need that not only for ECPG, but for libpostgres, libpgport, and
libpq too, if we want to check the installed ones (instead of recompiled).
Imagine that we will recompile psql (and use it) to perform installcheck
for the server instance. It will work but we'll miss an opportunity to
check whether the installed psql is working. I believe, it's the same
with ecpg (as now, we can even remove installed ecpg and have all the
tests passed).
> I am not opposed to fixing this, but one might also ask whether it's a
> good use of time, since the workaround is straightforward.
I'm not seeing a workaround to perform more complete installcheck
without modifying makefiles. So for me the question is whether the
increasing the testing surface justifies this use of time.
Best regards,
------
Alexander Lakhin
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: exclusion@gmail.com, robertmhaas@gmail.com
Subject: Re: make installcheck-world in a clean environment
In-Reply-To: <aff02bd6-20c9-0b6e-4e3c-a3428ce6568b@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox