pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Andres Freund <andres@anarazel.de>
To: Sandeep Thakkar <sandeep.thakkar@enterprisedb.com>
Cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: Joshua D. Drake <jd@commandprompt.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: David Steele <david@pgmasters.net>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Windows vs C99 (was Re: C99 compliance for src/port/snprintf.c)
Date: Wed, 22 Aug 2018 16:56:15 +0200
Message-ID: <aff7c79c-e05c-ed59-ad3a-123823846312@2ndquadrant.com> (raw)
In-Reply-To: <20180822120211.prl6uxspai4lahfs@alap3.anarazel.de>
References: <20180816130030.ijvgvshnu4hlhvzg@alap3.anarazel.de>
	<97d4b165-192d-3605-749c-f614a0c4e783@2ndquadrant.com>
	<20532.1534872560@sss.pgh.pa.us>
	<20180821173123.wliiykscjvtnbxk2@alap3.anarazel.de>
	<bc329070-e3b4-cc10-1502-818e600a5648@2ndQuadrant.com>
	<1d5946a3-aa85-a3ec-c8aa-b3e9b66dd5d9@commandprompt.com>
	<20180821204936.tqdmjolkoo2sv5og@alap3.anarazel.de>
	<303572b3-89a5-6177-d46a-e23b2b4d6caa@2ndQuadrant.com>
	<20180821232952.ixj6kgccoqcjp5gf@alap3.anarazel.de>
	<CANFyU94+wn2iN_ry=2SZFzxdFP6vAHA2+K0uhyyCS4YQWyyrxw@mail.gmail.com>
	<20180822120211.prl6uxspai4lahfs@alap3.anarazel.de>

On 22/08/2018 14:02, Andres Freund wrote:
> If we agree on that, I'm going to propose a patch that includes:
> - relevant cleanups to configure
> - adapts sources.sgml to refer to C99 instead of C89
> - add some trivial conversions to for(int i;;) and struct initializers,
>   so the relevant old animals fail
> - adds a configure check to enable errors with vla usage (-Werror=vla)

sounds good

> - do we want to make declarations at arbitrary points errors? It's
>   already a warning currently.

While there are legitimate criticisms, it's a standard feature in C,
C++, and many other languages, so I don't see what we'd gain by fighting it.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services




view thread (37+ messages)  latest in thread

Message-ID: <aff7c79c-e05c-ed59-ad3a-123823846312@2ndquadrant.com>
Permalink:  ../aff7c79c-e05c-ed59-ad3a-123823846312@2ndquadrant.com/
Also on:    postgresql.org/message-id/aff7c79c-e05c-ed59-ad3a-123823846312@2ndquadrant.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@2ndquadrant.com, andres@anarazel.de, sandeep.thakkar@enterprisedb.com, andrew.dunstan@2ndquadrant.com, jd@commandprompt.com, tgl@sss.pgh.pa.us, thomas.munro@enterprisedb.com, david@pgmasters.net, pgsql-hackers@lists.postgresql.org
  Subject: Re: Windows vs C99 (was Re: C99 compliance for src/port/snprintf.c)
  In-Reply-To: <aff7c79c-e05c-ed59-ad3a-123823846312@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox