public inbox for [email protected]
help / color / mirror / Atom feedFrom: Andres Freund <[email protected]>
To: Nathan Bossart <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: shihao zhong <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: Fixes inconsistent behavior in vacuum when it processes multiple relations
Date: Fri, 20 Mar 2026 16:32:48 -0400
Message-ID: <aglpy2jbnb75vufdx6hqkgokquzmoshcbnuxlcxhum4k7tyi7m@27m4hbxo2u2g> (raw)
In-Reply-To: <ab2iXwhRe3fFNPfp@nathan>
References: <aFWznvZtYZ3VJxgi@nathan>
<[email protected]>
<aFl1AB9ofnQrrckV@nathan>
<[email protected]>
<aFrSlSz9fi47j5Sr@nathan>
<[email protected]>
<aFwT31Rw-Oj-bgO9@nathan>
<[email protected]>
<rzxpxod4c4la62yvutyrvgoyilrl2fx55djaf2suidy7np5m6c@3l2ln476eadh>
<ab2iXwhRe3fFNPfp@nathan>
Hi,
On 2026-03-20 14:39:11 -0500, Nathan Bossart wrote:
> On Fri, Mar 20, 2026 at 12:27:49PM -0400, Andres Freund wrote:
> > Why wasn't it enough to add const markers and keep passing by pointer?
>
> IIRC the idea was to prevent similar problems in the future.
Seems using const VacuumParams *params should suffice for that? I don't think
it's particularly likely that we'll accept code that casts the const away and
then later get hurt by that.
> To avoid the extra #includes, we could instead use the back-patched version
> (e.g., commit 661643deda).
I'd probably not go quite there, at least the params should largely be const,
with a local on-stack copy where we do need to modify.
Greetings,
Andres Freund
view thread (32+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: Fixes inconsistent behavior in vacuum when it processes multiple relations
In-Reply-To: <aglpy2jbnb75vufdx6hqkgokquzmoshcbnuxlcxhum4k7tyi7m@27m4hbxo2u2g>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox