public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Erik Rijkers <[email protected]>
Cc: Daniel Gustafsson <[email protected]>
Cc: [email protected]
Subject: Re: pgsql: doc: Clarify OAuth validator authn_id logging
Date: Mon, 8 Jun 2026 08:56:04 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<[email protected]>
On Sat, Jun 06, 2026 at 02:36:24PM +0200, Erik Rijkers wrote:
> In doc/src/sgml/oauth-validators.sgml, and if I understand this text
> correctly (always a big if), then:
>
> "If the validator returns true and set result->authn_id then"
>
> should be:
> "If the validator returns true and sets result->authn_id then"
> (i.e., set -> sets)
>
> (added Michael in CC as he seems to collect these minimal patches, to be
> committed later as a group)
In auth-oauth.c, there is a validate() path setting the authn_id, so
your suggestion sounds right. I've grabbed that for later. My branch
can always be overwritten by somebody else's commit preference, of
course, so if you feel that this should be fixed separately, feel free
to go ahead.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, 2-signature.asc)
download
view thread (3+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: pgsql: doc: Clarify OAuth validator authn_id logging
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox