public inbox for [email protected]  

help / color / mirror / Atom feed

From: Nathan Bossart <[email protected]>
To: Kyotaro Horiguchi <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Subject: Re: enhance wraparound warnings
Date: Fri, 26 Jun 2026 13:06:36 -0500
Message-ID: <aj6_rEJqQ1KTe_OU@nathan> (raw)
In-Reply-To: <[email protected]>
References: <CAHGQGwEO1CnzVr42rJULGgPg9=89N0rOwNDmWKmjMM_-PVHB4Q@mail.gmail.com>
	<CALj2ACXk=r3WYzFoWz1Hh60PQ-=f+73qkW2Ne4avXwngncxc5Q@mail.gmail.com>
	<CAHGQGwHHPzYw2qbtwdkmyC+3pLW1aT1p6gUKx4WWhANiJhob2g@mail.gmail.com>
	<[email protected]>

On Fri, Jun 26, 2026 at 10:55:39AM +0900, Kyotaro Horiguchi wrote:
> I'm not sure I'm following this correctly, but the explanation above
> sounded to me as if the warning should report the number of IDs
> remaining before wraparound, e.g. "Approximately N MultiXactIds remain
> before wraparound", so I'm a bit confused by the proposed wording.

We already report the number of IDs remaining in the WARNING message.  In
v19, I've added a DETAIL message that also reports the percentage
remaining, with the hope that it makes the urgency clearer.

>> + errdetail("Approximately %.2f%% of MultiXactIds remain before wraparound.",
> 
> The attached patch adopts that wording. However, I'm not sure how to
> interpret it. The value is still expressed as a percentage, but it is
> no longer clear what that percentage is relative to.
> 
> Whichever approach we choose, I think the wording should be explicit.
> If the value is reported as a percentage, then something like "x.xx%
> of MultiXactId space remains" seems clearer to me. If it is reported
> as a count, then "N MultiXactIds remain" would make more sense.

I find both "percentage of IDs remaining" and "percentage of ID space
remaining" equally clear and have no strong opinion on the matter.

-- 
nathan

view thread (20+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: enhance wraparound warnings
  In-Reply-To: <aj6_rEJqQ1KTe_OU@nathan>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox