public inbox for [email protected]  
help / color / mirror / Atom feed
From: Bruce Momjian <[email protected]>
To: Tom Lane <[email protected]>
Cc: Baji Shaik <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] Doc: document standard_conforming_strings dump/restore incompatibility
Date: Thu, 18 Jun 2026 12:20:15 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CA+fm-RM8bG0G6SJDaMgWkKmtyf4QG=V5We1ViAG0tZ5PU67rLQ@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>

On Thu, Jun 18, 2026 at 11:34:46AM -0400, Tom Lane wrote:
> Bruce Momjian <[email protected]> writes:
> > On Wed, Jun 17, 2026 at 01:29:09PM -0400, Tom Lane wrote:
> >> I'm inclined to do more or less the attached, which also fixes what
> >> seems a thinko in the existing text: we should say that clients still
> >> support standard_conforming_strings = off, not
> >> escape_string_warning = off.
> 
> > I have applied a slightly modified version to master, attached.  The git
> > commit suggested this problem, but I didn't understand the impact at the
> > time I read it.
> 
> This didn't correct the point I complained of above: it still says
> 
> Client applications still support <literal>escape_string_warning = off</literal> for compatibility with old servers.
> 
> The notion of a client "supporting" escape_string_warning seems quite
> meaningless.  I think this intended to say standard_conforming_strings =
> off.

Ah, yes, I see my mistake now.  Attached patch applied using your wording.

-- 
  Bruce Momjian  <[email protected]>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Do not let urgent matters crowd out time for investment in the future.


Attachments:

  [text/x-diff] master.diff (789B, ../[email protected]/2-master.diff)
  download | inline diff:
diff --git a/doc/src/sgml/release-19.sgml b/doc/src/sgml/release-19.sgml
index 7c73cba11b7..96a09d6cd6e 100644
--- a/doc/src/sgml/release-19.sgml
+++ b/doc/src/sgml/release-19.sgml
@@ -116,7 +116,7 @@ or later versions of these applications, or use <literal>standard_conforming_str
 </para>
 
 <para>
-Client applications still support <literal>escape_string_warning = off</literal> for compatibility with old servers.  The server variable <varname>escape_string_warning</varname> has been removed as unnecessary.
+Client applications still support operations with servers having <literal>standard_conforming_strings = off</literal>, for compatibility with old servers.  The server variable <varname>escape_string_warning</varname> has been removed as unnecessary.
 </para>
 </listitem>
 


view thread (8+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Doc: document standard_conforming_strings dump/restore incompatibility
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox