public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Ewan Young <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Corey Huinker <[email protected]>
Subject: Re: Reject ill-formed range bounds histograms in pg_restore_attribute_stats()
Date: Thu, 9 Jul 2026 14:28:14 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAON2xHNGEB=Taga0P-osTcsbWTz6jha9yc74bkx9cASZTueA-g@mail.gmail.com>
References: <CAON2xHNM809WLR_g0ymKgU-tWxtbyH1Xvh4fqzRqy9YP2A59pg@mail.gmail.com>
<[email protected]>
<CAON2xHNGEB=Taga0P-osTcsbWTz6jha9yc74bkx9cASZTueA-g@mail.gmail.com>
On Wed, Jul 08, 2026 at 12:16:27PM +0800, Ewan Young wrote:
> Done in v2. I moved the check to stat_utils.c as stats_check_bounds_histogram()
> and now call it from both pg_restore_attribute_stats() and
> pg_restore_extended_stats(). In the extended path I reject an ill-formed
> histogram the same way the sibling stakinds there already do — WARNING plus
> goto pg_statistic_error.
Thanks. I have simplified some of the very-talkative comments,
adjusted one place where array_in_safe() was not mentioned (for
extstats expressions we rely on it for NULLs), tweaked a few more
minor things and applied on HEAD.
> Agreed — v2 targets master only, no back-branch patches.
If somebody has an argument to make here, please feel free.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (833B, ../[email protected]/2-signature.asc)
download
view thread (5+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: Reject ill-formed range bounds histograms in pg_restore_attribute_stats()
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox