agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Ewan Young <kdbase.hack@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Prevent crash when calling pgstat functions with unregistered stats kind
Date: Thu, 2 Jul 2026 05:02:36 +0000
Message-ID: <akXw7OIRj6L2eU/V@bdtpg> (raw)
In-Reply-To: <akXwVgoofSBd--pG@paquier.xyz>
References: <akS/ldidWeqG1FWk@bdtpg>
<CAON2xHOA23Oq8EERoV9ERBZof1O_vN-tYf0q58TwdkrTNZ-SPg@mail.gmail.com>
<akXalpb3zjPX3ZEl@bdtpg>
<akXebziFr_eQgQi8@paquier.xyz>
<akXjqbXRTLNcwHyE@bdtpg>
<akXkqov6wLbKwpAd@paquier.xyz>
<akXntNv2344hoc6L@bdtpg>
<akXsdHjBMbQk9qNT@bdtpg>
<akXwVgoofSBd--pG@paquier.xyz>
Hi,
On Thu, Jul 02, 2026 at 02:00:06PM +0900, Michael Paquier wrote:
> On Thu, Jul 02, 2026 at 04:43:32AM +0000, Bertrand Drouvot wrote:
> > On Thu, Jul 02, 2026 at 04:23:16AM +0000, Bertrand Drouvot wrote:
> >> Ok but what about extensions that don't call pgstat_register_kind() at all? Your
> >> point is that they would see the issue during the development of the extension? (If
> >> so, I think I could agree).
>
> Extensions doing custom stats have to call the register API, or
> they're broken. This is the same assumption as custom RMGRs. There
> are many ways to break the backend if you don't know what you do, just
> take hooks for example. That's just one of them.
>
> > Something like in the attached?
>
> Yes, that looks OK here.
That makes sense, I do agree.
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
view thread (13+ messages) latest in thread
Message-ID: <akXw7OIRj6L2eU/V@bdtpg>
Permalink: ../akXw7OIRj6L2eU%2FV@bdtpg/
Also on: postgresql.org/message-id/akXw7OIRj6L2eU/V@bdtpg
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: bertranddrouvot.pg@gmail.com, michael@paquier.xyz, kdbase.hack@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Prevent crash when calling pgstat functions with unregistered stats kind
In-Reply-To: <akXw7OIRj6L2eU/V@bdtpg>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox