agora inbox for pgsql-hackers@postgresql.org  

help / color / mirror / Atom feed

From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Jonathan Gonzalez V. <jonathan.abdiel@gmail.com>
Cc: Chao Li <li.evan.chao@gmail.com>
Cc: Euler Taveira <euler@eulerto.com>
Cc: japin <japinli@hotmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: log_min_messages per backend type
Date: Tue, 21 Jul 2026 15:07:33 +0200
Message-ID: <al9UOWZfiwOioZJB@alvherre.pgsql> (raw)
In-Reply-To: <87bjc0heaq.fsf@gmail.com>

On 2026-Jul-21, Jonathan Gonzalez V. wrote:

> but the
> second one is breaking the detection of the messages here:
> 
> @@ -2392,6 +2393,8 @@ check_log_min_messages(char **newval, void **extra, GucSource source)
>                 guc_free(rawstring);
>                 return false;
>         }
> +       rawstring_len = strlen(rawstring);
> +       guc_free(rawstring);
> 
> 
> The rawstring is being reference in the elemlist, so the free is making
> the string empty when is going to be used later:

Yeah, the second one is clearly busted.  Please consider it withdrawn.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"After a quick R of TFM, all I can say is HOLY CR** THAT IS COOL! PostgreSQL was
amazing when I first started using it at 7.2, and I'm continually astounded by
learning new features and techniques made available by the continuing work of
the development team."
Berend Tober, http://archives.postgresql.org/pgsql-hackers/2007-08/msg01009.php

view thread (58+ messages)

Message-ID: <al9UOWZfiwOioZJB@alvherre.pgsql>
Permalink:  ../al9UOWZfiwOioZJB@alvherre.pgsql/
Also on:    postgresql.org/message-id/al9UOWZfiwOioZJB@alvherre.pgsql

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: alvherre@alvh.no-ip.org, jonathan.abdiel@gmail.com, li.evan.chao@gmail.com, euler@eulerto.com, japinli@hotmail.com, andres@anarazel.de, pgsql-hackers@lists.postgresql.org
  Subject: Re: log_min_messages per backend type
  In-Reply-To: <al9UOWZfiwOioZJB@alvherre.pgsql>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox