pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Robert Haas <robertmhaas@gmail.com>
Cc: PostgreSQL Developers <pgsql-hackers@postgresql.org>
Subject: Re: pgbench stats per script & other stuff
Date: Wed, 22 Jul 2015 07:05:50 +0200 (CEST)
Message-ID: <alpine.DEB.2.10.1507220655270.5636@sto> (raw)
In-Reply-To: <CA+TgmoZhBFjff7-uJ0aLxPbke82u8YyC5n_tVUfRpHctpVtbtg@mail.gmail.com>
References: <alpine.DEB.2.10.1507171544450.26125@sto>
	<CA+Tgmoa=ud6E=4afK3srNj_4j8Cckm4OD_=0=uxSD5JVwsO4rQ@mail.gmail.com>
	<alpine.DEB.2.10.1507211626000.30948@sto>
	<CA+TgmoYQi7sPG+b_19Y4bn2wUPUujsSZ_qOF8nWZTrC1Pbqivg@mail.gmail.com>
	<alpine.DEB.2.10.1507211819460.30948@sto>
	<CA+TgmoZhBFjff7-uJ0aLxPbke82u8YyC5n_tVUfRpHctpVtbtg@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>


Hello Robert,

>> Pgbench *currently* already accept multiple "-f ..." options, and this is a
>> good thing to test realistic loads which may intermix several kind of
>> transactions, say a lot of readonly and some update or insert, and very rare
>> deletes...
>
> Hmm, I didn't realize that.  The code looks a bit inconsistent right
> now - e.g. we do support multiple files, but pgbench's options-parsing
> loop sets ttype to a value that depends only on the last of -f, -N,
> and -S encountered.

Indeed. However as with current pgbench <nothing>/-N/-S and -f are 
mutually exclusive it is ok to have ttype set as it is.

With the patch pgbench just executes scripts and the options are not 
mutually exclusive: some scripts are internal and others are not, but they 
are treated the same beyond initialization, which helps removing some code 
including the "ttype" variable you mention. The name of the script is kept 
in an SQLScript struct along with its commands, weight and stats.

-- 
Fabien.


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (92+ messages)  latest in thread

Message-ID: <alpine.DEB.2.10.1507220655270.5636@sto>
Permalink:  ../alpine.DEB.2.10.1507220655270.5636@sto/
Also on:    postgresql.org/message-id/alpine.DEB.2.10.1507220655270.5636@sto

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: coelho@cri.ensmp.fr, robertmhaas@gmail.com
  Subject: Re: pgbench stats per script & other stuff
  In-Reply-To: <alpine.DEB.2.10.1507220655270.5636@sto>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox