From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Josh Berkus <josh@agliodbs.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: PostgreSQL Developers <pgsql-hackers@postgresql.org>
Subject: Re: pgbench stats per script & other stuff
Date: Wed, 22 Jul 2015 07:25:58 +0200 (CEST)
Message-ID: <alpine.DEB.2.10.1507220706260.5636@sto> (raw)
In-Reply-To: <55AEDDA4.8020009@agliodbs.com>
References: <alpine.DEB.2.10.1507171544450.26125@sto>
<CA+Tgmoa=ud6E=4afK3srNj_4j8Cckm4OD_=0=uxSD5JVwsO4rQ@mail.gmail.com>
<alpine.DEB.2.10.1507211626000.30948@sto>
<CA+TgmoYQi7sPG+b_19Y4bn2wUPUujsSZ_qOF8nWZTrC1Pbqivg@mail.gmail.com>
<alpine.DEB.2.10.1507211819460.30948@sto>
<WM!aa4cff4a48647dfeb51adbc23faaba1f82d825d5edc7fcfe10aa08a36243c5ffb656060d76dd428676a64e1e72c8a672!@asav-2.01.com>
<55AEDDA4.8020009@agliodbs.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Hello Josh,
>> Maybe -f file.sql:weight (yuk from my point of view, but it can be done
>> easily).
>
> Maybe it's past time for pgbench to have a config file?
That is an idea. For "simple" usage, for backward compatibility and for
people like me who like them, ISTM that options are fine too:-)
Also this may mean adding a dependency to some YAML library, configure
issues (I'm not sure whether pg currently uses YAML, and JSON is quite
verbose), maybe conditionals around the feature to compile without the
dependency, more documentation...
I'm not sure all that is desirable just for weighting scripts.
> Given that we want to define some per-workload options, the config file
> would probably need to be YAML or JSON, e.g.:
>
> [...]
>
> script1:
> file: script1.bench
> weight: 3
> script2:
> file: script2.bench
> weight: 1
>
> the above would execute a pgbench with 16 clients, 4 threads, "script1"
> three times as often as script2, and report stats at the script (rather
> than SQL statement) level.
Yep. Probably numbering within field names should be avoided, so a list of
records that could look like:
scripts:
- file: foo1.sql
weight: 9
- file: foo2.sql
- internal: tpc-b
weight: 2
--
Fabien.
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: coelho@cri.ensmp.fr, josh@agliodbs.com, robertmhaas@gmail.com
Subject: Re: pgbench stats per script & other stuff
In-Reply-To: <alpine.DEB.2.10.1507220706260.5636@sto>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox