public inbox for [email protected]
help / color / mirror / Atom feedFrom: Fabien COELHO <[email protected]>
To: Michael Paquier <[email protected]>
Cc: Julien Rouhaud <[email protected]>
Cc: [email protected] <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: psql - add SHOW_ALL_RESULTS option
Date: Fri, 9 Apr 2021 20:04:11 +0200 (CEST)
Message-ID: <alpine.DEB.2.22.394.2104091947240.3439700@pseudo> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<alpine.DEB.2.22.394.2104062323150.2555247@pseudo>
<OSZPR01MB631017521EE6887ADC9492E8FD759@OSZPR01MB6310.jpnprd01.prod.outlook.com>
<alpine.DEB.2.22.394.2104071516470.2724014@pseudo>
<OSZPR01MB6310325023E8B4109BB2AB90FD749@OSZPR01MB6310.jpnprd01.prod.outlook.com>
<20210408163050.fca7dwb37zszbsmm@nol>
<alpine.DEB.2.22.394.2104081858500.3192110@pseudo>
<20210408171135.ekhdf5nvqss554q3@nol>
<YG+okFpc3JaKN/[email protected]>
<alpine.DEB.2.22.394.2104090828330.3253600@pseudo>
<[email protected]>
>> Yep, it looks much better. I found it strange that the later did a reset but
>> was not doing the set.
>>
>> Attached v2 does as you suggest.
>
> Close enough. I was thinking about this position of the attached,
> which is more consistent with the rest.
Given the structural complexity of the function, the end of the file
seemed like a good place to have an all-path-guaranteed reset.
I find it a little bit strange to have the Set at the upper level and the
Reset in many… but not all branches, though.
For instance the on_error_rollback_savepoint/svptcmd branch includes a
reset long after many other conditional resets, I cannot guess whether the
initial set is still active or has been long wiped out and this query is
just not cancellable.
Also, ISTM that in the worst case a cancellation request is sent to a
server which is idle, in which case it will be ignored, so the code should
be in no hurry to clean it, at least not at the price of code clarity.
Anyway, the place you suggest seems ok.
--
Fabien.
view thread (104+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: psql - add SHOW_ALL_RESULTS option
In-Reply-To: <alpine.DEB.2.22.394.2104091947240.3439700@pseudo>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox