pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Yugo NAGATA <nagata@sraoss.co.jp>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Gregory Smith <gregsmithpgsql@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: david.christensen@crunchydata.com
Subject: Re: pgbench logging broken by time logic changes
Date: Thu, 17 Jun 2021 13:49:47 +0200 (CEST)
Message-ID: <alpine.DEB.2.22.394.2106171157370.2693553@pseudo> (raw)
In-Reply-To: <20210617175542.ad6b9b82926d8469e8520324@sraoss.co.jp>
References: <CAHLJuCW_8Vpcr0=t6O_gozrg3wXXWXZXDioYJd3NhvKriqgpfQ@mail.gmail.com>
	<CA+hUKG+jhatozihmqy4=Ufd0OHwZadEd_vg-_+26hE3f4C3TgQ@mail.gmail.com>
	<YMqbcj7SHtVb0OeS@paquier.xyz>
	<alpine.DEB.2.22.394.2106170929500.2693553@pseudo>
	<alpine.DEB.2.22.394.2106171017250.2693553@pseudo>
	<20210617175542.ad6b9b82926d8469e8520324@sraoss.co.jp>


> I found you forgot to fix printProgressReport().

Indeed.

> Also, according to the document, interval_start in Aggregated Logging
> seems to be printed in seconds instead of ms.

Indeed. I'm unsure about what we should really want there, but for a beta 
bug fix I agree that it must simply comply to the old documented behavior.

> The attached patch includes these fixes.

Thanks. Works for me.

-- 
Fabien.





view thread (64+ messages)  latest in thread

Message-ID: <alpine.DEB.2.22.394.2106171157370.2693553@pseudo>
Permalink:  ../alpine.DEB.2.22.394.2106171157370.2693553@pseudo/
Also on:    postgresql.org/message-id/alpine.DEB.2.22.394.2106171157370.2693553@pseudo

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: coelho@cri.ensmp.fr, nagata@sraoss.co.jp, michael@paquier.xyz, thomas.munro@gmail.com, gregsmithpgsql@gmail.com, david.christensen@crunchydata.com
  Subject: Re: pgbench logging broken by time logic changes
  In-Reply-To: <alpine.DEB.2.22.394.2106171157370.2693553@pseudo>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox