pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Yugo NAGATA <nagata@sraoss.co.jp>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Marina Polyakova <m.polyakova@postgrespro.ru>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Teodor Sigaev <teodor@sigaev.ru>
Subject: Re: [HACKERS] WIP    aPatch: Pgbench Serialization and deadlock errors
Date: Sat, 26 Jun 2021 10:20:11 +0200 (CEST)
Message-ID: <alpine.DEB.2.22.394.2106261015070.482873@pseudo> (raw)
In-Reply-To: <20210625200113.b411821946a08b5f7d6b8f73@sraoss.co.jp>
References: <20181116195952.nq4ak4r7cbzvoher@alvherre.pgsql>
	<f900fd87b5c58a0ff71c1f08f3c91e5f@postgrespro.ru>
	<CA+hUKGKBTdhanHJd4Y+opANz4Fs+VeOAbFG7TsM=tK+EBWKP4g@mail.gmail.com>
	<alpine.DEB.2.21.2003092038190.7227@pseudo>
	<CA+hUKGJ=tv00eph4ve4XTgbyRo8dFWT=v-cEPxBxratWZpd5hw@mail.gmail.com>
	<20210524112910.444fbfdfbff747bd3b9720ee@sraoss.co.jp>
	<20210622235459.4b2e38e268488014226b3262@sraoss.co.jp>
	<alpine.DEB.2.22.394.2106230914180.1117163@pseudo>
	<20210625200113.b411821946a08b5f7d6b8f73@sraoss.co.jp>


Hello Yugo-san,

>> I'm wondering whether we could use "vars" instead of "variables" as a
>> struct field name and function parameter name, so that is is shorter and
>> more distinct from the type name "Variables". What do you think?
>
> The struct "Variables" has a field named "vars" which is an array of
> "Variable" type. I guess this is a reason why "variables" is used instead
> of "vars" as a name of "Variables" type variable so that we could know
> a variable's type is Variable or Variables.  Also, in order to refer to
> the field, we would use
>
> vars->vars[vars->nvars]
>
> and there are nested "vars". Could this make a codereader confused?

Hmmm… Probably. Let's keep "variables" then.

-- 
Fabien.

view thread (82+ messages)  latest in thread

Message-ID: <alpine.DEB.2.22.394.2106261015070.482873@pseudo>
Permalink:  ../alpine.DEB.2.22.394.2106261015070.482873@pseudo/
Also on:    postgresql.org/message-id/alpine.DEB.2.22.394.2106261015070.482873@pseudo

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: coelho@cri.ensmp.fr, nagata@sraoss.co.jp, thomas.munro@gmail.com, m.polyakova@postgrespro.ru, alvherre@2ndquadrant.com, teodor@sigaev.ru
  Subject: Re: [HACKERS] WIP    aPatch: Pgbench Serialization and deadlock errors
  In-Reply-To: <alpine.DEB.2.22.394.2106261015070.482873@pseudo>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox