pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Gregory Smith <gregsmithpgsql@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: david.christensen@crunchydata.com
Subject: Re: pgbench logging broken by time logic changes
Date: Fri, 9 Jul 2021 07:14:32 +0200 (CEST)
Message-ID: <alpine.DEB.2.22.394.2107090645160.233209@pseudo> (raw)
In-Reply-To: <CA+hUKGKCQ4DUo1diCg6SPhnpaYWF37uEPbHhy=FKv4Cnuqn8_g@mail.gmail.com>
References: <202106231308.lxr26cahwxuc@alvherre.pgsql>
	<alpine.DEB.2.22.394.2106232158120.1601973@pseudo>
	<YNPsPAUoVDCpPOGk@paquier.xyz>
	<alpine.DEB.2.22.394.2106240815480.1687456@pseudo>
	<c031d7e6-a903-bac0-be96-26adc8903e2c@dunslane.net>
	<YNUGcznZps/dhZK4@paquier.xyz>
	<alpine.DEB.2.22.394.2106300934360.1788422@pseudo>
	<YNwlu5S6UlsB2DQz@paquier.xyz>
	<CA+hUKG+RMaozHhU7mBMyk6cFE69M9rPE9aOuvNpbjWbvNqUL9Q@mail.gmail.com>
	<alpine.DEB.2.22.394.2106301131200.1875747@pseudo>
	<alpine.DEB.2.22.394.2106301153030.1875747@pseudo>
	<CA+hUKGJcxWd7yM=QzBSd4xd6DqxEzGhWZRNPepuLuoP0rCj3-Q@mail.gmail.com>
	<alpine.DEB.2.22.394.2107010926141.2024567@pseudo>
	<CA+hUKG+2NAmDZ9g4GMjy939AsVifj117O40M1h7zUj02bzwjcA@mail.gmail.com>
	<alpine.DEB.2.22.394.2107081510410.170227@pseudo>
	<CA+hUKGKCQ4DUo1diCg6SPhnpaYWF37uEPbHhy=FKv4Cnuqn8_g@mail.gmail.com>


Hello Thomas,

>>> Isn't it better if we only have to throw away the first one?).
>>
>> This should be the user decision to drop it or not, not the tool 
>> producing it, IMO.
>
> Let me try this complaint again. [...]

I understand your point.

For me removing silently the last bucket is not right because the sum of 
aggregates does not match the final grand total. This change is 
intentional and borders on a bug fix, which is what this patch was doing, 
even if it is also a small behavioral change: We should want the detailed 
and final reports in agreement.

I do agree that users should probably ignore the first and last lines.

> See attached.

Works for me: patch applies, global and local check ok. I'm fine with it.

If it was me, I'd still show the last bucket, but it does not matter much.

-- 
Fabien.





view thread (64+ messages)  latest in thread

Message-ID: <alpine.DEB.2.22.394.2107090645160.233209@pseudo>
Permalink:  ../alpine.DEB.2.22.394.2107090645160.233209@pseudo/
Also on:    postgresql.org/message-id/alpine.DEB.2.22.394.2107090645160.233209@pseudo

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: coelho@cri.ensmp.fr, thomas.munro@gmail.com, michael@paquier.xyz, andrew@dunslane.net, alvherre@alvh.no-ip.org, gregsmithpgsql@gmail.com, david.christensen@crunchydata.com
  Subject: Re: pgbench logging broken by time logic changes
  In-Reply-To: <alpine.DEB.2.22.394.2107090645160.233209@pseudo>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox