public inbox for [email protected]
help / color / mirror / Atom feedFrom: Fabien COELHO <[email protected]>
To: Peter Eisentraut <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: psql - add SHOW_ALL_RESULTS option
Date: Wed, 23 Mar 2022 13:58:36 +0100 (CET)
Message-ID: <alpine.DEB.2.22.394.2203231342180.3205455@pseudo> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<alpine.DEB.2.22.394.2107221655020.25741@pseudo>
<[email protected]>
<alpine.DEB.2.22.394.2109251058000.3216312@pseudo>
<alpine.DEB.2.22.394.2110021622530.2817726@pseudo>
<[email protected]>
<alpine.DEB.2.22.394.2112230703530.2668598@pseudo>
<[email protected]>
<alpine.DEB.2.22.394.2201040851220.3857182@pseudo>
<alpine.DEB.2.22.394.2201081931170.731324@pseudo>
<[email protected]>
<alpine.DEB.2.22.394.2201150938470.3378943@pseudo>
<[email protected]>
<alpine.DEB.2.22.394.2203041443080.538147@pseudo>
<alpine.DEB.2.22.394.2203121726590.3679190@pseudo>
<[email protected]>
<alpine.DEB.2.22.394.2203171859410.1198186@pseudo>
<[email protected]>
Hello Peter,
>> Attached v17 is another try. The point is to record the current status,
>> whatever it is, buggy or not, and to update the test when libpq fixes
>> things, whenever this is done.
>
> [...]
>
> The expected output (which passes) contains this line twice:
>
> psql:<stdin>:2: FATAL: terminating connection due to administrator command
> psql:<stdin>:2: FATAL: terminating connection due to administrator command
> If I paste this test case into current master without your patch, I only get
> this line once. So your patch is changing this output. The whole point of
> the libpq fixes was to not have this duplicate output. So I think something
> is still wrong somewhere.
Hmmm. Yes and no:-)
The previous path inside libpq silently ignores intermediate results, it
skips all results to keep only the last one. The new approach does not
discard resultss silently, hence the duplicated output, because they are
actually there and have always been there in the first place, they were
just ignored: The previous "good" result is really a side effect of a bad
implementation in a corner case, which just becomes apparent when opening
the list of results.
So my opinion is still to dissociate the libpq "bug/behavior" fix from
this feature, as they are only loosely connected, because it is a very
corner case anyway.
An alternative would be to remove the test case, but I'd prefer that it is
kept.
If you want to wait for libpq to provide a solution for this corner case,
I'm afraid that "never" is the likely result, especially as no test case
exercices this path to show that there is a problem somewhere, so nobody
should care to fix it. I'm not sure it is even worth it given the highly
special situation which triggers the issue, which is not such an actual
problem (ok, the user is told twice that there was a connection loss, no
big deal).
--
Fabien.
view thread (113+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: psql - add SHOW_ALL_RESULTS option
In-Reply-To: <alpine.DEB.2.22.394.2203231342180.3205455@pseudo>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox