pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: pgsql-hackers@lists.postgresql.org <pgsql-hackers@lists.postgresql.org>
Subject: Re: psql - add SHOW_ALL_RESULTS option
Date: Tue, 4 Jan 2022 08:55:34 +0100 (CET)
Message-ID: <alpine.DEB.2.22.394.2201040851220.3857182@pseudo> (raw)
In-Reply-To: <46259d13-5f90-1475-3c85-d7a597a2b862@enterprisedb.com>
References: <69C0B369-570C-4524-8EE4-BCCACECB6BEE@amazon.com>
	<20210412193301.GA11204@alvherre.pgsql>
	<YHeVHH0wVcRwdogL@paquier.xyz>
	<3738387.1618451507@sss.pgh.pa.us>
	<alpine.DEB.2.22.394.2104151336060.191178@pseudo>
	<451a2111-3757-c511-9413-8f8af531a167@enterprisedb.com>
	<alpine.DEB.2.22.394.2106121130400.4105466@pseudo>
	<CALDaNm0+pzGgp-M1mAoUVYRtjadbWYuB96J8RaV9iH3+HA8FTA@mail.gmail.com>
	<alpine.DEB.2.22.394.2107151742300.1705285@pseudo>
	<18c78a01-4a34-9dd4-f78b-6860f1420c8e@enterprisedb.com>
	<alpine.DEB.2.22.394.2107221655020.25741@pseudo>
	<6954328d-96f2-77f7-735f-7ce493a40949@enterprisedb.com>
	<alpine.DEB.2.22.394.2109251058000.3216312@pseudo>
	<alpine.DEB.2.22.394.2110021622530.2817726@pseudo>
	<2570e2ae-fa0f-aac9-f72f-bb59a9983a20@enterprisedb.com>
	<alpine.DEB.2.22.394.2112230703530.2668598@pseudo>
	<46259d13-5f90-1475-3c85-d7a597a2b862@enterprisedb.com>


Hello Peter,

> With this "voluntary crash", the regression test output is now
>
>     psql                         ... ok     (test process exited with exit 
> code 2)      281 ms
>
> Normally, I'd expect this during development if there was a crash somewhere, 
> but showing this during a normal run now, and moreover still saying "ok",

Well, from a testing perspective, the crash is voluntary and it is 
indeed ok:-)

> is quite weird and confusing.  Maybe this type of test should be done in 
> the TAP framework instead.

It could. Another simpler option: add a "psql_voluntary_crash.sql" with 
just that test instead of modifying the "psql.sql" test script? That would 
keep the test exit code information, but the name of the script would make 
things clearer?

Also, if non zero status do not look so ok, should they be noted as bad?

-- 
Fabien.





view thread (127+ messages)  latest in thread

Message-ID: <alpine.DEB.2.22.394.2201040851220.3857182@pseudo>
Permalink:  ../alpine.DEB.2.22.394.2201040851220.3857182@pseudo/
Also on:    postgresql.org/message-id/alpine.DEB.2.22.394.2201040851220.3857182@pseudo

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: coelho@cri.ensmp.fr, peter.eisentraut@enterprisedb.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: psql - add SHOW_ALL_RESULTS option
  In-Reply-To: <alpine.DEB.2.22.394.2201040851220.3857182@pseudo>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox