From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Tatsuo Ishii <ishii@sraoss.co.jp>
Cc: alvherre@alvh.no-ip.org
Cc: nagata@sraoss.co.jp
Cc: thomas.munro@gmail.com
Cc: m.polyakova@postgrespro.ru
Cc: pgsql-hackers@postgresql.org
Cc: teodor@sigaev.ru
Subject: Re: [HACKERS] WIP aPatch: Pgbench Serialization and deadlock errors
Date: Sun, 10 Apr 2022 09:37:15 +0200 (CEST)
Message-ID: <alpine.DEB.2.22.394.2204100928170.232675@pseudo> (raw)
In-Reply-To: <4183048.1649536705@sss.pgh.pa.us>
References: <20220404.101431.333095021655639605.t-ishii@sranhm.sra.co.jp>
<alpine.DEB.2.22.394.2204041518020.3174331@pseudo>
<20220405.083805.1138012899895218258.t-ishii@sranhm.sra.co.jp>
<20220406.100005.1796406557268900302.t-ishii@sranhm.sra.co.jp>
<4183048.1649536705@sss.pgh.pa.us>
Hello Tom,
> The buildfarm is still complaining about the synopsis being too
> wide for PDF format. I think what we ought to do is give up on
> using a <synopsis> for log lines at all, and instead convert the
> documentation into a tabular list of fields. Proposal attached,
> which also fixes a couple of outright errors.
Looks ok. Html doc generation ok.
While looking at the html outpout, the "pgbench" command line just below
wraps strangely:
pgbench --aggregate-interval=10 --time=20 --client=10 --log --rate=1000
--latency-limit=10 --failures-detailed --max-tries=10 test
ISTM that there should be no nl in the <textinput>pgbench …</textinput>
section, although maybe it would trigger a complaint in the pdf format.
> One thing that this doesn't fix is that the existing text appears
> to suggest that the "failures" column is something different from
> the sum of the serialization_failures and deadlock_failures
> columns, which it's obvious from the code is not so. If this isn't
> a code bug then I think we ought to just drop that column entirely,
> because it's redundant.
Ok. Fine with me. Possibly at some point there was the idea that there
could be other failures counted, but there are none. Also, there has been
questions about the failures detailed option, or whether the reports
should always be detailed, and the result may be some kind of not
convincing compromise.
> (BTW, now that I've read this stuff I am quite horrified by how
> the non-aggregated log format has been mangled for error retries,
> and will be probably be submitting a proposal to change that.
> But that's a different issue.)
Indeed, any improvement is welcome!
--
Fabien.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: coelho@cri.ensmp.fr, tgl@sss.pgh.pa.us, ishii@sraoss.co.jp, alvherre@alvh.no-ip.org, nagata@sraoss.co.jp, thomas.munro@gmail.com, m.polyakova@postgrespro.ru, teodor@sigaev.ru
Subject: Re: [HACKERS] WIP aPatch: Pgbench Serialization and deadlock errors
In-Reply-To: <alpine.DEB.2.22.394.2204100928170.232675@pseudo>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox