agora inbox for pgsql-hackers@postgresql.org  
help / color / mirror / Atom feed
From: Christoph Berg <myon@debian.org>
To: Tomas Vondra <tomas@vondra.me>
Cc: wenhui qiu <qiuwenhuifx@gmail.com>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: Andres Freund <andres@anarazel.de>
Cc: Jelte Fennema-Nio <postgres@jeltef.nl>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Japin Li <japinli@hotmail.com>
Cc: Fujii Masao <masao.fujii@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: John Naylor <johncnaylorls@gmail.com>
Subject: Re: WAL compression setting after PostgreSQL LZ4 default change
Date: Fri, 31 Jul 2026 15:10:29 +0200
Message-ID: <amyexT2WCaoCBc7G@msg.df7cb.de> (raw)
In-Reply-To: <e160948f-c272-4afb-8109-d82b06e52d11@vondra.me>
References: <ak19GnnQE46n6myy@paquier.xyz>
	<CAGECzQQ+OWP+yafyUp_g3DDY-cKYoyATUEJRkgatLU6n70kH_A@mail.gmail.com>
	<ak2Es90xR35P2jPB@msg.df7cb.de>
	<CAGjGUALBMSzJ=ngL0k0CR6MqM+1W=Y+=+MSv+Z4R5jvmr47P5A@mail.gmail.com>
	<50d60598-3fbf-4344-8b07-bf02114f7fd0@vondra.me>
	<gf7azery3i6en6pljduxgxb2edikhbrmnvl7tkrt2wryezrrye@b4a3yo37d7pl>
	<1314f5843859d5f83d5eb0a47b15d9291567cf40.camel@cybertec.at>
	<CAGjGUA+ERbxcGzfiKDT2LpqU095E5=E2BvqCWXMTKgm-jns14Q@mail.gmail.com>
	<amyWkBMR4hKVUZFv@msg.df7cb.de>
	<e160948f-c272-4afb-8109-d82b06e52d11@vondra.me>

Re: Tomas Vondra
> The one thing I don't quite like on the patch is that it actually
> defaults to zstd before lz4. Which seems to not quite match the intent
> to have both toast and wal default to the same thing. I don't have a
> strong preference for either algorithm, but I also don't see why to put
> zstd before lz4. I'd do it the other way around, i.e. lz4->zstd->pglz.

About the intent, I see it more as "PG19 is the version that switched
away from pglz". It could be lz4 for both, or it could be lz4 for
TOAST and zstd for WAL.

There is some value in having both the same, but I'd defer to what the
others are saying.

I don't have a preference either way. This was just the last thing
expressed here. (If we can't agree on that point, could we please
still make the change and just toss a coin about this "bit"? :D)

Christoph






view thread (44+ messages)  latest in thread

Message-ID: <amyexT2WCaoCBc7G@msg.df7cb.de>
Permalink:  ../amyexT2WCaoCBc7G@msg.df7cb.de/
Also on:    postgresql.org/message-id/amyexT2WCaoCBc7G@msg.df7cb.de

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: myon@debian.org, tomas@vondra.me, qiuwenhuifx@gmail.com, laurenz.albe@cybertec.at, andres@anarazel.de, postgres@jeltef.nl, michael@paquier.xyz, japinli@hotmail.com, masao.fujii@gmail.com, johncnaylorls@gmail.com
  Subject: Re: WAL compression setting after PostgreSQL LZ4 default change
  In-Reply-To: <amyexT2WCaoCBc7G@msg.df7cb.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox