agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Nathan Bossart <nathandbossart@gmail.com>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Sami Imseih <samimseih@gmail.com>
Cc: David Rowley <dgrowleyml@gmail.com>
Cc: Jim Nasby <jnasby@upgrade.com>
Cc: Greg Burd <greg@burd.me>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Robert Treat <rob@xzilla.net>
Cc: Jeremy Schneider <schneider@ardentperf.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: another autovacuum scheduling thread
Date: Mon, 31 Aug 2026 11:47:56 -0500
Message-ID: <apWwPMCotJ7OUOWb@nathan> (raw)
In-Reply-To: <CALj2ACVVc+k2-qyCMJ2OJ464vrkxYX=_U0Zsv9LYPJrwgmsTOQ@mail.gmail.com>
References: <acRROBvlokDLQZlh@nathan>
<CAApHDvrD9YZ8RBgb6NDtzyay1PsFReLvWHVqUCMFw1=qxM1N1g@mail.gmail.com>
<acRdY_cxDvff5zW4@nathan>
<CAApHDvqTDRbSVoGCv=1Y_TsAiggfEyGzH2QE+Hp57xwcBtfAOQ@mail.gmail.com>
<acVjtJA2F68vdYTB@nathan>
<CAApHDvrUQPZcjQK7+PAcXoXc664AizDiBY4thBh1kqEHUouPPQ@mail.gmail.com>
<acafxccEv5ZcU0Ym@nathan>
<CAA5RZ0vvDsnLEw9DW6SOmy8EdwRirPdYi2saM_3fgLY_96JdUg@mail.gmail.com>
<apWcbq91BAfhmsKU@nathan>
<CALj2ACVVc+k2-qyCMJ2OJ464vrkxYX=_U0Zsv9LYPJrwgmsTOQ@mail.gmail.com>
On Mon, Aug 31, 2026 at 08:49:08AM -0700, Bharath Rupireddy wrote:
> On Mon, Aug 31, 2026 at 8:23 AM Nathan Bossart <nathandbossart@gmail.com> wrote:
>> Claude noticed a corner case that needs handling. In short, if the freeze
>> score weights are high enough, the pow() calls can have the opposite of the
>> intended effect, since the freeze scores may be less than 1. Patch
>> attached.
>
> Nice catch! Yes, it seems like an obvious issue and the fix looks good to me.
Thanks for looking.
> Can we add some tests for HEAD for the autovacuum scoring feature? I
> understand it's a bit hard to get the tests to run deterministically,
> but if it's worth it, I can give it a try.
Seems worth a try.
--
nathan
view thread (150+ messages) latest in thread
Message-ID: <apWwPMCotJ7OUOWb@nathan>
Permalink: ../apWwPMCotJ7OUOWb@nathan/
Also on: postgresql.org/message-id/apWwPMCotJ7OUOWb@nathan
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, bharath.rupireddyforpostgres@gmail.com, samimseih@gmail.com, dgrowleyml@gmail.com, jnasby@upgrade.com, greg@burd.me, robertmhaas@gmail.com, rob@xzilla.net, schneider@ardentperf.com
Subject: Re: another autovacuum scheduling thread
In-Reply-To: <apWwPMCotJ7OUOWb@nathan>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox