agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Álvaro Herrera <alvherre@kurilemu.de>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: shveta malik <shveta.malik@gmail.com>
Cc: Zhijie Hou (Fujitsu) <houzj.fnst@fujitsu.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Remove stale XXX comment in logical launcher
Date: Thu, 3 Sep 2026 20:12:10 +0200
Message-ID: <apm3dWJyEOjYyeSR@alvherre.pgsql> (raw)
In-Reply-To: <CAA4eK1L2NaVOGt7uWFMRqBr+GXP28mDNxhgYrW59xfX+ZfnRQQ@mail.gmail.com>
On 2026-Sep-03, Amit Kapila wrote:
> On Thu, Sep 3, 2026 at 11:56 AM shveta malik <shveta.malik@gmail.com> wrote:
> > I agree. However, the comments never mention that this is a physical
> > slot, making it easy to misconstrue it as a logical one. Do you think
> > we can add the keyword 'physical' in the comment above this Drop()
> > or/and above CreateConflictDetectionSlot or/and above macro
> > CONFLICT_DETECTION_SLOT?
>
> Adding such a comment at the time of creation sounds reasonable to me.
> I would still like to check with Alvaro who added this comment in
> commit 2af1dc89282bea681201cf66e2bb32537294e623 whether such a comment
> would make it easier to follow this part of code?
I agree that having a comment stating that the slot we hold is
necessarily physical would be good. It wouldn't hurt to see exactly
what is being proposed though.
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"[PostgreSQL] is a great group; in my opinion it is THE best open source
development communities in existence anywhere." (Lamar Owen)
view thread (130+ messages) latest in thread
Message-ID: <apm3dWJyEOjYyeSR@alvherre.pgsql>
Permalink: ../apm3dWJyEOjYyeSR@alvherre.pgsql/
Also on: postgresql.org/message-id/apm3dWJyEOjYyeSR@alvherre.pgsql
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@kurilemu.de, amit.kapila16@gmail.com, shveta.malik@gmail.com, houzj.fnst@fujitsu.com
Subject: Re: Remove stale XXX comment in logical launcher
In-Reply-To: <apm3dWJyEOjYyeSR@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox