From: Álvaro Herrera <alvherre@kurilemu.de>
To: Chao Li <li.evan.chao@gmail.com>
Cc: Fujii Masao <masao.fujii@gmail.com>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Nathan Bossart <nathandbossart@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: fixes for a few GUC descriptions
Date: Fri, 11 Sep 2026 11:14:03 +0200
Message-ID: <aqPFjLQs5KzqAiCl@alvherre.pgsql> (raw)
In-Reply-To: <DB0C90EE-0485-405E-80D5-A1A6703E52C8@gmail.com>
On 2026-Sep-11, Chao Li wrote:
> > On Sep 11, 2026, at 08:54, Fujii Masao <masao.fujii@gmail.com> wrote:
> > - long_desc => '-1 disables the timeout and waits for the receiver to
> > catch up; 0 does not wait for the receiver to catch up.',
> > + long_desc => '-1 disables the timeout. 0 means do not wait for the
> > receiver to catch up.',
>
> Yeah, here -1 is really more like “wait forever”, so just saying “disables the timeout” feels like it loses that distinction.
Maybe it should say "0 means do not wait, -1 means wait indefinitely."
This complements the short_desc,
Sets the maximum time the server waits during shutdown for all WAL data
to be replicated to the receiver.
I think the words "for the receiver to catch up" is somehow at odds with
the short_desc's "for all WAL data to be replicated". They should be
saying the same thing, but aren't.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
Si no sabes adonde vas, es muy probable que acabes en otra parte.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@kurilemu.de, li.evan.chao@gmail.com, masao.fujii@gmail.com, bharath.rupireddyforpostgres@gmail.com, nathandbossart@gmail.com
Subject: Re: fixes for a few GUC descriptions
In-Reply-To: <aqPFjLQs5KzqAiCl@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox