agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Álvaro Herrera <alvherre@kurilemu.de>
To: Chao Li <li.evan.chao@gmail.com>
Cc: shihao zhong <zhong950419@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: REPACK (CONCURRENTLY) decoding worker is canceled by lock_timeout
Date: Fri, 11 Sep 2026 18:33:52 +0200
Message-ID: <aqQslOwhDkbNYerk@alvherre.pgsql> (raw)
In-Reply-To: <902950F0-E94A-4DFF-93EE-8B10469F51A1@gmail.com>
On 2026-Sep-10, Chao Li wrote:
> > On Sep 10, 2026, at 11:21, shihao zhong <zhong950419@gmail.com> wrote:
> > Done in v2, through the DSM segment the worker already attaches to.
I think this is pretty reasonable.
> Auto-vacuum explicitly overrides all four settable session timeouts
> (statement_timeout, transaction_timeout, lock_timeout, and
> idle_in_transaction_session_timeout) to zero, while this worker only
> handles the latter two. I understand that statement_timeout and
> idle_in_transaction_session_timeout are probably never armed by this
> worker, so functionally they may not need special handling.
Hmm, but REPACK is not autovacuum; it's quite different in fact, in that
REPACK is intended to always be invoked manually, while autovacuum runs
on its own. On the other hand, because REPACK refuses to run in a
transaction block, transaction_timeout and
idle_in_transaction_session_timeout don't really apply, so I'm not
seeing the potential for problems.
> My concern is that the inconsistency might lead to confusion to future
> readers. Does it make sense to either remove those two from
> auto-vacuum worker or set them to repack worker as well?
I decidedly don't want to touch autovacuum. Although I'm not sure I see
the reason why the transaction-based timeouts are relevant for
autovacuum.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
view thread (15+ messages) latest in thread
Message-ID: <aqQslOwhDkbNYerk@alvherre.pgsql>
Permalink: ../aqQslOwhDkbNYerk@alvherre.pgsql/
Also on: postgresql.org/message-id/aqQslOwhDkbNYerk@alvherre.pgsql
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@kurilemu.de, li.evan.chao@gmail.com, zhong950419@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: REPACK (CONCURRENTLY) decoding worker is canceled by lock_timeout
In-Reply-To: <aqQslOwhDkbNYerk@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox