From: Nathan Bossart <nathandbossart@gmail.com>
To: Salvatore Dipietro <dipiets@amazon.it>
Cc: pgsql-hackers@lists.postgresql.org
Cc: mrdrivingduck@gmail.com
Cc: andres@anarazel.de
Cc: tgl@sss.pgh.pa.us
Cc: dipietro.salvatore@gmail.com
Subject: Re: use a non-locking initial test in TAS_SPIN on AArch64
Date: Tue, 15 Sep 2026 09:51:37 -0500
Message-ID: <aqlbeci-pDwk9dQX@nathan> (raw)
In-Reply-To: <20260915114623.431827-1-dipiets@amazon.it>
References: <Z4gDWMbR6uqV1mhR@nathan>
<20260915114623.431827-1-dipiets@amazon.it>
On Tue, Sep 15, 2026 at 11:46:23AM +0000, Salvatore Dipietro wrote:
> I'd like to propose backporting this commit 3d0b4b1068 ("Use a
> non-locking initial test in TAS_SPIN on AArch64.", Nathan Bossart,
> 2025-01-10), which first shipped in PostgreSQL 18, to the supported
> back branches: REL_17_STABLE, REL_16_STABLE and REL_15_STABLE.
I think that's fine. It was likely an oversight when AArch64 support was
first added to this file, anyway. We could also back-patch to v14, but
that would look a little different since it is missing commit a82a5eee31
("Use ISB as a spin-delay instruction on ARM64"). Since v14 is set to go
out-of-support in a couple months, I'd probably just stop at v15 and call
it a day, though.
> With huge_pages=on both effects largely disappear: huge pages mask the
> paging defect, and TTAS is neutral.
>
> The change is a one-line, so a backport looks low-risk and would spare
> pre-18 AArch64 users a severe regression as PREEMPT_LAZY kernels ship.
I'm curious why you are testing without huge pages enabled. My
understanding is that any serious workload on the kinds of machines you are
using for your benchmarks would use them.
--
nathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, dipiets@amazon.it, pgsql-hackers@lists.postgresql.org, mrdrivingduck@gmail.com, andres@anarazel.de, tgl@sss.pgh.pa.us, dipietro.salvatore@gmail.com
Subject: Re: use a non-locking initial test in TAS_SPIN on AArch64
In-Reply-To: <aqlbeci-pDwk9dQX@nathan>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox