From: Michael Paquier <michael@paquier.xyz>
To: Alexandre Felipe <o.alexandre.felipe@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pg_regress: schedule multi-line test groups
Date: Thu, 17 Sep 2026 17:03:38 +0900
Message-ID: <aque2pNHYkJC5iyR@paquier.xyz> (raw)
In-Reply-To: <CAE8JnxObF4iYtNA-3w+JDNT2YsbS5YMyGiPMnYU0Gd0CtUOMGQ@mail.gmail.com>
References: <CAE8JnxObF4iYtNA-3w+JDNT2YsbS5YMyGiPMnYU0Gd0CtUOMGQ@mail.gmail.com>
On Thu, Sep 17, 2026 at 08:57:51AM +0100, Alexandre Felipe wrote:
> This was motivated by two rebases on the SLOPE patch [1] this week due to
> changes in parallel_schedule. Also I find much easier to parse the list
> using this syntax, if we stick with one test per line we get the benefit of
> counting tests by looking at the line numbers.
>
> I used a `goto` to keep the number of touched lines small, and facilitate
> your review.
I'd +1 something like that in the schedule files, even if we only
limit the number of tests per line to be up to 20.
+test:
+ boolean
+ char
+ name
At least, let's make the whitespace vs tab policy consistent. ;)
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../aque2pNHYkJC5iyR@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, o.alexandre.felipe@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: pg_regress: schedule multi-line test groups
In-Reply-To: <aque2pNHYkJC5iyR@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox