pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feedRe: AW: PG19beta1: GCC 16.1.1 warning: ‘actual_arg_types’ may be used uninitialized in clauses.c
5+ messages / 3 participants
[nested] [flat]
Commits from this thread:
2026-09-24 2c10c2ce4d Silence another "may be used uninitialized" compiler warning.
* Re: AW: PG19beta1: GCC 16.1.1 warning: ‘actual_arg_types’ may be used uninitialized in clauses.c
@ 2026-06-18 16:05 Nathan Bossart <nathandbossart@gmail.com>
0 siblings, 1 reply; 5+ messages in thread
From: Nathan Bossart @ 2026-06-18 16:05 UTC (permalink / raw)
To: Hans Buschmann <buschmann@nidsa.net>; +Cc: Erik Rijkers <er@xs4all.nl>; Álvaro Herrera <alvherre@kurilemu.de>; pgsql-hackers
On Thu, Jun 18, 2026 at 11:33:23AM +0000, Hans Buschmann wrote:
> I also can confirm that this silences the compiler warning of GCC 16.1.1.
Thanks! I'm debating whether to back-patch this to unsupported branches.
IIUC it qualifies. I'm getting ready to bump up the minimum supported
version of pg_dump and friends to v10, so maybe I should stop there. But
also, stopping at v14 might be good enough for something small like this.
Any opinions?
--
nathan
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: AW: PG19beta1: GCC 16.1.1 warning: ‘actual_arg_types’ may be used uninitialized in clauses.c
@ 2026-06-18 16:08 Álvaro Herrera <alvherre@kurilemu.de>
parent: Nathan Bossart <nathandbossart@gmail.com>
0 siblings, 1 reply; 5+ messages in thread
From: Álvaro Herrera @ 2026-06-18 16:08 UTC (permalink / raw)
To: Nathan Bossart <nathandbossart@gmail.com>; +Cc: Hans Buschmann <buschmann@nidsa.net>; Erik Rijkers <er@xs4all.nl>; pgsql-hackers
On 2026-Jun-18, Nathan Bossart wrote:
> On Thu, Jun 18, 2026 at 11:33:23AM +0000, Hans Buschmann wrote:
> > I also can confirm that this silences the compiler warning of GCC 16.1.1.
>
> Thanks! I'm debating whether to back-patch this to unsupported branches.
> IIUC it qualifies. I'm getting ready to bump up the minimum supported
> version of pg_dump and friends to v10, so maybe I should stop there. But
> also, stopping at v14 might be good enough for something small like this.
> Any opinions?
I'd stop at 14 and call it a day. It doesn't prevent building, which is
IIRC the criteria we use for the older branches.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"You're _really_ hosed if the person doing the hiring doesn't understand
relational systems: you end up with a whole raft of programmers, none of
whom has had a Date with the clue stick." (Andrew Sullivan)
https://postgr.es/m/20050809113420.GD2768@phlogiston.dyndns.org
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: AW: PG19beta1: GCC 16.1.1 warning: ‘actual_arg_types’ may be used uninitialized in clauses.c
@ 2026-06-18 16:30 Nathan Bossart <nathandbossart@gmail.com>
parent: Álvaro Herrera <alvherre@kurilemu.de>
0 siblings, 1 reply; 5+ messages in thread
From: Nathan Bossart @ 2026-06-18 16:30 UTC (permalink / raw)
To: Álvaro Herrera <alvherre@kurilemu.de>; +Cc: Hans Buschmann <buschmann@nidsa.net>; Erik Rijkers <er@xs4all.nl>; pgsql-hackers
On Thu, Jun 18, 2026 at 06:08:12PM +0200, Álvaro Herrera wrote:
> I'd stop at 14 and call it a day. It doesn't prevent building, which is
> IIRC the criteria we use for the older branches.
WFM. Committed, thanks.
--
nathan
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: AW: PG19beta1: GCC 16.1.1 warning: ‘actual_arg_types’ may be used uninitialized in clauses.c
@ 2026-09-24 19:51 Tom Lane <tgl@sss.pgh.pa.us>
parent: Nathan Bossart <nathandbossart@gmail.com>
0 siblings, 1 reply; 5+ messages in thread
From: Tom Lane @ 2026-09-24 19:51 UTC (permalink / raw)
To: Nathan Bossart <nathandbossart@gmail.com>; +Cc: Álvaro Herrera <alvherre@kurilemu.de>; Hans Buschmann <buschmann@nidsa.net>; Erik Rijkers <er@xs4all.nl>; pgsql-hackers
Nathan Bossart <nathandbossart@gmail.com> writes:
> On Thu, Jun 18, 2026 at 06:08:12PM +0200, Álvaro Herrera wrote:
>> I'd stop at 14 and call it a day. It doesn't prevent building, which is
>> IIRC the criteria we use for the older branches.
> WFM. Committed, thanks.
Since I updated 'mamba' to NetBSD 11 (which has gcc 12.5.0),
it's been spewing a closely related warning:
parse_func.c: In function 'LookupFuncWithArgs':
parse_func.c:2457:15: warning: 'argoids' may be used uninitialized [-Wmaybe-uninitialized]
2457 | oid = LookupFuncNameInternal(func->args_unspecified ? objtype : OBJECT_ROUTINE,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2458 | func->objname, nargs, argoids,
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2459 | false, missing_ok,
| ~~~~~~~~~~~~~~~~~~
2460 | &lookupError);
| ~~~~~~~~~~~~~
parse_func.c:2234:1: note: by argument 4 of type 'const Oid *' {aka 'const unsigned int *'} to 'LookupFuncNameInternal' declared here
2234 | LookupFuncNameInternal(ObjectType objtype, List *funcname,
| ^~~~~~~~~~~~~~~~~~~~~~
parse_func.c:2395:33: note: 'argoids' declared here
2395 | Oid argoids[FUNC_MAX_ARGS];
| ^~~~~~~
Presumably this could be silenced in the same way as in f04781df5.
I haven't troubled so far because I don't see any other BF animals
producing the same warning, but perhaps we should silence this one
too?
regards, tom lane
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: AW: PG19beta1: GCC 16.1.1 warning: ‘actual_arg_types’ may be used uninitialized in clauses.c
@ 2026-09-24 20:02 Nathan Bossart <nathandbossart@gmail.com>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 5+ messages in thread
From: Nathan Bossart @ 2026-09-24 20:02 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Álvaro Herrera <alvherre@kurilemu.de>; Hans Buschmann <buschmann@nidsa.net>; Erik Rijkers <er@xs4all.nl>; pgsql-hackers
On Thu, Sep 24, 2026 at 03:51:05PM -0400, Tom Lane wrote:
> Presumably this could be silenced in the same way as in f04781df5.
> I haven't troubled so far because I don't see any other BF animals
> producing the same warning, but perhaps we should silence this one
> too?
Seems reasonable to me.
--
nathan
^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2026-09-24 20:02 UTC | newest]
Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-06-18 16:05 Re: AW: PG19beta1: GCC 16.1.1 warning: ‘actual_arg_types’ may be used uninitialized in clauses.c Nathan Bossart <nathandbossart@gmail.com>
2026-06-18 16:08 ` Álvaro Herrera <alvherre@kurilemu.de>
2026-06-18 16:30 ` Nathan Bossart <nathandbossart@gmail.com>
2026-09-24 19:51 ` Tom Lane <tgl@sss.pgh.pa.us>
2026-09-24 20:02 ` Nathan Bossart <nathandbossart@gmail.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox